From owner-svn-ports-head@freebsd.org Tue Jan 22 10:09:19 2019 Return-Path: Delivered-To: svn-ports-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 92E5414B71DC; Tue, 22 Jan 2019 10:09:19 +0000 (UTC) (envelope-from cmt@burggraben.net) Received: from smtp.burggraben.net (smtp.burggraben.net [IPv6:2a01:4f8:140:50a2::3:1]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client CN "ns.exwg.net", Issuer "Christoph Moench-Tegeder" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 308A384829; Tue, 22 Jan 2019 10:09:19 +0000 (UTC) (envelope-from cmt@burggraben.net) Received: from localhost (localhost [127.0.0.1]) by smtp.burggraben.net (Postfix) with ESMTP id 349926002FE; Tue, 22 Jan 2019 11:09:17 +0100 (CET) X-Spam-Scanned: by amavisd-new at exwg.net Received: from smtp.burggraben.net ([127.0.0.1]) by localhost (ns.burggraben.net [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id nACY5Qgvf8vy; Tue, 22 Jan 2019 11:09:12 +0100 (CET) Received: from elch.exwg.net (elch.exwg.net [IPv6:2001:470:7120:1:127b:44ff:fe4f:148d]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client CN "elch.exwg.net", Issuer "Christoph Moench-Tegeder" (verified OK)) by smtp.burggraben.net (Postfix) with ESMTPS; Tue, 22 Jan 2019 11:09:12 +0100 (CET) Received: by elch.exwg.net (Postfix, from userid 1000) id 6A5701399FC; Tue, 22 Jan 2019 11:09:11 +0100 (CET) Date: Tue, 22 Jan 2019 11:09:11 +0100 From: Christoph Moench-Tegeder To: Jan Beich Cc: svn-ports-head@freebsd.org, svn-ports-all@freebsd.org, ports-committers@freebsd.org Subject: Re: svn commit: r490910 - in head: Mk Mk/Uses mail/thunderbird www/firefox www/firefox-esr www/firefox-i18n www/firefox/files www/palemoon www/seamonkey Message-ID: <20190122100911.GA77378@elch.exwg.net> References: <201901212303.x0LN3jR3059519@repo.freebsd.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.11.2 (2019-01-07) X-Rspamd-Queue-Id: 308A384829 X-Spamd-Bar: ------ Authentication-Results: mx1.freebsd.org X-Spamd-Result: default: False [-6.97 / 15.00]; NEURAL_HAM_MEDIUM(-1.00)[-0.999,0]; NEURAL_HAM_SHORT(-0.97)[-0.971,0]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; REPLY(-4.00)[] X-BeenThere: svn-ports-head@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: SVN commit messages for the ports tree for head List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 22 Jan 2019 10:09:19 -0000 Excuse my hijacking of this thread... firefox 65 fails to build (poudirere, amd64, 12.0) when option WAYLAND is disabled (that't not the default), first error is: : In file included from /wrkdirs/usr/ports/www/firefox/work/.build/gfx/webrender_bindings/Unified_cpp_webrender_bindings0.cpp:20: : /wrkdirs/usr/ports/www/firefox/work/firefox-65.0/gfx/webrender_bindings/RenderCompositor.cpp:35:47: error: use of undeclared identifier 'RenderCompositorEGL'; did you mean 'RenderCompositorOGL'? : UniquePtr eglCompositor = RenderCompositorEGL::Create(aWidget); : ^~~~~~~~~~~~~~~~~~~ : RenderCompositorOGL Looking at patch-bug1514156 with perfect hindsight, that's somewhat obvious as the include of RenderCompositorEGL.h is guarded with an #ifdef MOZ_WAYLAND (line 20 of RenderCompositor.cpp), but the first use of RenderCompositorEGL (line 35, see above) is wrapped in an #ifdef MOZ_WIDGET_GTK. Having changed some OPTIONS, the build bombs out in a different way while I'm writing this... I'll have to investigate, because in my hopeleslsy optimistic way I changed more than one option at once. Regards, Christoph -- Spare Space