Date: Thu, 06 May 2010 10:10:23 -0700 From: Xin LI <delphij@delphij.net> To: Bruce Evans <brde@optusnet.com.au> Cc: svn-src-head@FreeBSD.ORG, svn-src-all@FreeBSD.ORG, src-committers@FreeBSD.ORG, Xin LI <delphij@FreeBSD.ORG> Subject: Re: svn commit: r207677 - head/usr.bin/find Message-ID: <4BE2F7FF.9070902@delphij.net> In-Reply-To: <20100506105825.B18998@delplex.bde.org> References: <201005052124.o45LOJES067973@svn.freebsd.org> <20100506105825.B18998@delplex.bde.org>
next in thread | previous in thread | raw e-mail | index | archive | help
-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 On 2010/05/05 18:00, Bruce Evans wrote: > On Wed, 5 May 2010, Xin LI wrote: > >> Log: >> Move SCCS tags to comments as they were already #if 0'ed. > > This is explicitly disrecommended in style(9): > > All VCS (version control system) revision identification in files > obtained from elsewhere should be maintained, including, where > applica- > ble, multiple IDs showing a file's history. In general, do not > edit for- > eign IDs or their infrastructure. Unless otherwise wrapped (such as > ``#if defined(LIBC_SCCS)''), enclose both in ``#if 0 ... #endif'' > to hide > any uncompilable bits and to keep the IDs out of object files. > Only add > ``From: '' in front of foreign VCS IDs if the file is renamed. Sorry for that. I thought that the style(9) approach actually creates more diffs but I'll obey these rule. Cheers, - -- Xin LI <delphij@delphij.net> http://www.delphij.net/ FreeBSD - The Power to Serve! Live free or die -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.14 (FreeBSD) iQEcBAEBAgAGBQJL4vf/AAoJEATO+BI/yjfB8UQH/1RFuhSbshX6f7096nhQPsEv poHVmmYvEivhaE25PZkSSyBTVws4arN1IuBGerS2OKqBn+E3L09dHiSOxFG0qiTN wnNcfXZo/OuniSZIhcvBhkO0EgXsAhNacPDxrx+WjjQthnQPoM4bprVgfk6mHd+/ x8BXxxLwtbMawwf/QlA97/h2TpMab/Hmx4J3pV7dBLjDVzEmnPPiD0mMaqnffAW7 Z3nRNhydea014fUMUDr/wpIx0XOFJsIIHrPwWK5odQ1TUGxLqly4mBCwy//ydVLK bdUVnmU26j50zC6dQSvsO/tQEd4Katw/ITat2vLn5cA9i2KnWP4HMEGulGyW9JI= =19LB -----END PGP SIGNATURE-----
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?4BE2F7FF.9070902>