Skip site navigation (1)Skip section navigation (2)
Date:      Fri, 8 Apr 2011 00:53:27 +0000
From:      "b. f." <bf1783@googlemail.com>
To:        Rene Ladan <rene@freebsd.org>
Cc:        cvs-ports@freebsd.org, cvs-all@freebsd.org, ports-committers@freebsd.org
Subject:   Re: cvs commit: ports/www/chromium Makefile
Message-ID:  <BANLkTikmUZsHNjw2Jpe8Y7v5CD6WkZGtoQ@mail.gmail.com>
In-Reply-To: <201104072239.p37Md9oh031253@repoman.freebsd.org>
References:  <201104072239.p37Md9oh031253@repoman.freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help
On 4/7/11, Rene Ladan <rene@freebsd.org> wrote:
> rene        2011-04-07 22:39:09 UTC
>
>   FreeBSD ports repository
>
>   Modified files:
>     www/chromium         Makefile
>   Log:
>   Cleanup Makefile a bit more:
>   - Convert two explicit dependencies to a USE_GNOME and USE_XORG component
>   - Use buildtime SSE2 detection instead of an OPTION

How is this last change above going to work for building i386
packages, if the package-building machine has SSE2, but other machines
that use the packages do not? (Or vice versa, for that matter.)  You
may add some sanity checks, and make the effect of the option
i386-specific, but I don't think that you can safely remove this
option entirely --  and the default setting has to allow packages to
work on all i386.

b.



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?BANLkTikmUZsHNjw2Jpe8Y7v5CD6WkZGtoQ>