Skip site navigation (1)Skip section navigation (2)
Date:      Tue, 29 Jul 2008 10:16:14 +0900
From:      Pyun YongHyeon <pyunyh@gmail.com>
To:        Peter Jeremy <peterjeremy@optushome.com.au>
Cc:        cvs-src@freebsd.org, src-committers@freebsd.org, cvs-all@freebsd.org, Pyun YongHyeon <yongari@freebsd.org>
Subject:   Re: cvs commit: src/sys/conf NOTES files src/sys/modules Makefile src/sys/modules/jme Makefile
Message-ID:  <20080729011614.GA96129@cdnetworks.co.kr>
In-Reply-To: <20080728191208.GA40936@server.vk2pj.dyndns.org>
References:  <200805270154.m4R1sjAn023638@repoman.freebsd.org> <20080728191208.GA40936@server.vk2pj.dyndns.org>

next in thread | previous in thread | raw e-mail | index | archive | help
On Tue, Jul 29, 2008 at 05:12:08AM +1000, Peter Jeremy wrote:
 > [A bit late but I only just noticed]
 > On 2008-May-27 01:54:45 +0000, Pyun YongHyeon <yongari@freebsd.org> wrote:
 > >yongari     2008-05-27 01:54:45 UTC
 > >
 > >  FreeBSD src repository
 > >
 > >  Modified files:
 > >    sys/conf             NOTES files 
 > >    sys/modules          Makefile 
 > >  Added files:
 > >    sys/modules/jme      Makefile 
 > >  Log:
 > >  Hook up jme(4) to the build.
 > >  
 > >  Revision  Changes    Path
 > >  1.1492    +1 -0      src/sys/conf/NOTES
 > ...
 > 
 > Whilst you have included a comment about jme(4) in NOTES, there is no
 > associated 'device jme' line.  All other NIC drivers have both a comment
 > line and an actual device line apart from msk(4) and stge(4) (both of
 > which you also committed).
 > 
 > This bug has been carried through in your MFCs.
 > 
 > Could you please update NOTES to include both lines for all three devices
 > in all relevant branches so ensure that LINT builds include these devices.
 > 

Done. I'll make sure to MFC the change.

Thanks for pointing out!
-- 
Regards,
Pyun YongHyeon



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20080729011614.GA96129>