From owner-svn-src-head@freebsd.org Tue Aug 30 16:40:11 2016 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id B9BCEBC8FFD; Tue, 30 Aug 2016 16:40:11 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from bigwig.baldwin.cx (bigwig.baldwin.cx [IPv6:2001:470:1f11:75::1]) (using TLSv1 with cipher DHE-RSA-CAMELLIA256-SHA (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 9BAB8F1B; Tue, 30 Aug 2016 16:40:11 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from ralph.baldwin.cx (c-73-231-226-104.hsd1.ca.comcast.net [73.231.226.104]) by bigwig.baldwin.cx (Postfix) with ESMTPSA id 9C9CFB962; Tue, 30 Aug 2016 12:40:10 -0400 (EDT) From: John Baldwin To: src-committers@freebsd.org Cc: svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r305032 - head/sys/dev/cxgbe Date: Tue, 30 Aug 2016 07:22:46 -0700 Message-ID: <1531680.3M3PdubIRh@ralph.baldwin.cx> User-Agent: KMail/4.14.3 (FreeBSD/10.3-STABLE; KDE/4.14.3; amd64; ; ) In-Reply-To: <201608292247.u7TMlEf3050457@repo.freebsd.org> References: <201608292247.u7TMlEf3050457@repo.freebsd.org> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.2.7 (bigwig.baldwin.cx); Tue, 30 Aug 2016 12:40:10 -0400 (EDT) X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 30 Aug 2016 16:40:11 -0000 On Monday, August 29, 2016 10:47:14 PM John Baldwin wrote: > Author: jhb > Date: Mon Aug 29 22:47:14 2016 > New Revision: 305032 > URL: https://svnweb.freebsd.org/changeset/base/305032 > > Log: > Use device_verbose() to undo device_quiet() when detaching from t[45]iovX. > > The device quiet flag is not automatically reset on detach, so it is > inherited by other device drivers (e.g. when switching a device driver > over to ppt for PCI pass through). Cope with this behavior by explicitly > marking the device verbose during detach so that the next driver can make > its own decision. > > Sponsored by: Chelsio Communications Even though device_quiet() is documented to work this way, I think it is probably worth considering changing this so it only affects a single attach/detach life cycle. That is, clearing the flag in device_detach() (but also handling device_probe() correctly since it is typically called during probe and if multiple drivers probe a device, you only want the behavior of the "winning" driver to be in effect when you call attach). -- John Baldwin