From owner-svn-src-head@freebsd.org Wed Nov 13 23:46:49 2019 Return-Path: Delivered-To: svn-src-head@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id C7E531C121C; Wed, 13 Nov 2019 23:46:49 +0000 (UTC) (envelope-from carpeddiem@gmail.com) Received: from mail-io1-f67.google.com (mail-io1-f67.google.com [209.85.166.67]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 47D1VJ4jbMz4Z0D; Wed, 13 Nov 2019 23:46:48 +0000 (UTC) (envelope-from carpeddiem@gmail.com) Received: by mail-io1-f67.google.com with SMTP id 1so4702270iou.4; Wed, 13 Nov 2019 15:46:48 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=Gjv6aGCly/sR1N5sOLiUsfEub0DAOxsFDAZmxJ4TrpI=; b=slcK9imlrSVk8Rld8LKoH+YmMk3s72XqV5v0QZ9zdvm7ZE9SSm6bIDDOXV2C05JUR6 oAAS47Lw5RO2697fHj9Vubjht4eh7gQ7HqG7teXDRHr3h43o6ME5kQSFEACgLODL+zrL 26MfmJ5JvjDJALbm49rcpehN2+KNQEFv9XX6baQCBcdOwDef336eERi820Z4d4nxquQ3 vZk/SVcppHAT/5SsCVHs/JzAs/p2koWHqL+padpcSsofBrh7xeJciD6tY2MeVVp/4SLz KIQX8GlGcuyTbqP4jXSPoYMyCb+OF9Fxr03hfyR82k6wiGWjzFU2I22gRRHFygRmk18G VWxA== X-Gm-Message-State: APjAAAWXw4/+gD4dqvHNwmlfbfQYmEJ/v57lIEu4tJxDqeUscMSGeZ7l nyiTY97VHcR/tx5B5rl4+k2Y/dopNr6Pk03kutQBcw== X-Google-Smtp-Source: APXvYqyppN1LSyBcL0SQkzYiSVf96irmTlrPGIgL0krY/YeOVNBmAEjjj/G+RMGrTfGtyIkOOkmzdFtsHHl8v7yzR8A= X-Received: by 2002:a6b:7e0a:: with SMTP id i10mr1122794iom.120.1573688807098; Wed, 13 Nov 2019 15:46:47 -0800 (PST) MIME-Version: 1.0 References: <201911132151.xADLptvc074883@repo.freebsd.org> <20191113224640.GX2707@kib.kiev.ua> <20191113225535.GA17978@spindle.one-eyed-alien.net> <20191113231709.GY2707@kib.kiev.ua> In-Reply-To: <20191113231709.GY2707@kib.kiev.ua> From: Ed Maste Date: Wed, 13 Nov 2019 15:00:04 -0500 Message-ID: Subject: Re: svn commit: r354694 - in head: lib/libc/gen sys/sys To: Konstantin Belousov Cc: Brooks Davis , src-committers , svn-src-all , svn-src-head Content-Type: text/plain; charset="UTF-8" X-Rspamd-Queue-Id: 47D1VJ4jbMz4Z0D X-Spamd-Bar: --- Authentication-Results: mx1.freebsd.org; dkim=none; dmarc=none; spf=pass (mx1.freebsd.org: domain of carpeddiem@gmail.com designates 209.85.166.67 as permitted sender) smtp.mailfrom=carpeddiem@gmail.com X-Spamd-Result: default: False [-3.31 / 15.00]; ARC_NA(0.00)[]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; FROM_HAS_DN(0.00)[]; R_SPF_ALLOW(-0.20)[+ip4:209.85.128.0/17]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; MIME_GOOD(-0.10)[text/plain]; MIME_TRACE(0.00)[0:+]; DMARC_NA(0.00)[freebsd.org]; RCPT_COUNT_FIVE(0.00)[5]; TO_MATCH_ENVRCPT_SOME(0.00)[]; TO_DN_ALL(0.00)[]; RCVD_IN_DNSWL_NONE(0.00)[67.166.85.209.list.dnswl.org : 127.0.5.0]; IP_SCORE(-1.31)[ip: (-1.30), ipnet: 209.85.128.0/17(-3.18), asn: 15169(-1.99), country: US(-0.05)]; FORGED_SENDER(0.30)[emaste@freebsd.org,carpeddiem@gmail.com]; FREEMAIL_TO(0.00)[gmail.com]; RWL_MAILSPIKE_POSSIBLE(0.00)[67.166.85.209.rep.mailspike.net : 127.0.0.17]; R_DKIM_NA(0.00)[]; FREEMAIL_ENVFROM(0.00)[gmail.com]; ASN(0.00)[asn:15169, ipnet:209.85.128.0/17, country:US]; FROM_NEQ_ENVFROM(0.00)[emaste@freebsd.org,carpeddiem@gmail.com]; RCVD_TLS_ALL(0.00)[]; RCVD_COUNT_TWO(0.00)[2] X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 13 Nov 2019 23:46:49 -0000 On Wed, 13 Nov 2019 at 18:17, Konstantin Belousov wrote: > > On Wed, Nov 13, 2019 at 10:55:35PM +0000, Brooks Davis wrote: > > On Thu, Nov 14, 2019 at 12:46:40AM +0200, Konstantin Belousov wrote: > > > On Wed, Nov 13, 2019 at 09:51:55PM +0000, Brooks Davis wrote: > > > > Author: brooks > > > > Date: Wed Nov 13 21:51:55 2019 > > > > New Revision: 354694 > > > > URL: https://svnweb.freebsd.org/changeset/base/354694 > > > > > > > > Log: > > > > elf_aux_info: Add support for AT_EXECPATH. > > > > > > > > Reviewed by: emaste, sef > > > > MFC after: 3 days > > > > Sponsored by: DARPA, AFRL > > > > Differential Revision: https://reviews.freebsd.org/D22353 > > > > > > > > Modified: > > > > head/lib/libc/gen/auxv.3 > > > > head/lib/libc/gen/auxv.c > > > > head/sys/sys/param.h > > > > > > > > Modified: head/lib/libc/gen/auxv.3 > > > > ============================================================================== > > > > --- head/lib/libc/gen/auxv.3 Wed Nov 13 21:49:46 2019 (r354693) > > > > +++ head/lib/libc/gen/auxv.3 Wed Nov 13 21:51:55 2019 (r354694) > > > > @@ -24,7 +24,7 @@ > > > > .\" > > > > .\" $FreeBSD$ > > > > .\" > > > > -.Dd April 25, 2019 > > > > +.Dd November 13, 2019 > > > > .Dt ELF_AUX_INFO 3 > > > > .Os > > > > .Sh NAME > > > > @@ -48,6 +48,10 @@ can be requested: > > > > .Bl -tag -width AT_OSRELDATE > > > > .It AT_CANARY > > > > The canary value for SSP. > > > > +.It AT_EXECPATH > > > > +The path of executed program. > > > > +This will not be present if the process was initialized by > > > This is too strong statement. The auxv element might be not present > > > if vn_fullpath(9) failed, otherwise we do provide the path. > > > > > > > +.Xr fexecve 2 . > > > > Would it be more accurate to change it from "will" to "may"? > > Referencing vn_fullpath(9) seems unhelpful in userspace programmer > > documentation. > > I do not suggest to reference vn_fullpath(9). 'May' is enough, you might > also mention namecache. Perhaps also mention that in that case it's not guaranteed to be the pathname that was actually used, if there are multiple links.