Date: Fri, 06 May 2011 16:38:00 +0300 From: Andriy Gapon <avg@FreeBSD.org> To: Kostik Belousov <kostikbel@gmail.com> Cc: current@FreeBSD.org, multimedia@FreeBSD.org Subject: Re: dsp mmap change Message-ID: <4DC3F9B8.3030505@FreeBSD.org> In-Reply-To: <20110506133204.GE48734@deviant.kiev.zoral.com.ua> References: <4DC3B764.4030801@FreeBSD.org> <20110506133204.GE48734@deviant.kiev.zoral.com.ua>
next in thread | previous in thread | raw e-mail | index | archive | help
on 06/05/2011 16:32 Kostik Belousov said the following: > On Fri, May 06, 2011 at 11:55:00AM +0300, Andriy Gapon wrote: >> >> I would like to ask for a review and/or testing of the following patch: >> http://people.freebsd.org/~avg/dev_dsp_mmap.diff >> >> It's supposed to fix an issue described here: >> http://lists.freebsd.org/pipermail/freebsd-multimedia/2011-February/011691.html >> >> In short, the following pseudo-code should do the right thing: >> fd = open(/dev/dsp, O_RDWR); >> mmap(PROT_READ, fd); >> mmap(PROT_WRITE, fd); >> >> Thank you! > > I think that you have to call PCM_GIANT_LEAVE() when returning > EINVAL on the vm_pager_alloc() failure. Yes, thank you. > Your patch hardcodes an assumption that sndbufs are always > contiguous. I was unable to convince myself that this is true. I think that this should be true for the case when DMA is used? But, yes, very good point. -- Andriy Gapon
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?4DC3F9B8.3030505>