From owner-freebsd-current@FreeBSD.ORG  Thu May 29 21:44:48 2008
Return-Path: <owner-freebsd-current@FreeBSD.ORG>
Delivered-To: current@FreeBSD.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 72491106566B;
	Thu, 29 May 2008 21:44:48 +0000 (UTC)
	(envelope-from thompsa@FreeBSD.org)
Received: from pele.citylink.co.nz (pele.citylink.co.nz [202.8.44.226])
	by mx1.freebsd.org (Postfix) with ESMTP id 2E04C8FC19;
	Thu, 29 May 2008 21:44:47 +0000 (UTC)
	(envelope-from thompsa@FreeBSD.org)
Received: from localhost (localhost [127.0.0.1])
	by pele.citylink.co.nz (Postfix) with ESMTP id BF0EF2D3B6;
	Fri, 30 May 2008 09:44:46 +1200 (NZST)
X-Virus-Scanned: Debian amavisd-new at citylink.co.nz
Received: from pele.citylink.co.nz ([127.0.0.1])
	by localhost (pele.citylink.co.nz [127.0.0.1]) (amavisd-new, port 10024)
	with ESMTP id gYZ1+DZde+jT; Fri, 30 May 2008 09:44:42 +1200 (NZST)
Received: from citylink.fud.org.nz (unknown [202.8.44.45])
	by pele.citylink.co.nz (Postfix) with ESMTP;
	Fri, 30 May 2008 09:44:42 +1200 (NZST)
Received: by citylink.fud.org.nz (Postfix, from userid 1001)
	id 34BDA11428; Fri, 30 May 2008 09:46:05 +1200 (NZST)
Date: Thu, 29 May 2008 14:46:05 -0700
From: Andrew Thompson <thompsa@FreeBSD.org>
To: Coleman Kane <cokane@FreeBSD.org>
Message-ID: <20080529214604.GA68753@citylink.fud.org.nz>
References: <1212093692.1681.8.camel@localhost>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1212093692.1681.8.camel@localhost>
User-Agent: Mutt/1.5.17 (2007-11-01)
Cc: current@FreeBSD.org
Subject: Re: ndis(4) patch to replace obsolete if_watchdog interface
X-BeenThere: freebsd-current@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Discussions about the use of FreeBSD-current
	<freebsd-current.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>, 
	<mailto:freebsd-current-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-current>
List-Post: <mailto:freebsd-current@freebsd.org>
List-Help: <mailto:freebsd-current-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>,
	<mailto:freebsd-current-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 29 May 2008 21:44:48 -0000

On Thu, May 29, 2008 at 04:41:32PM -0400, Coleman Kane wrote:
> Hi,
> 
> I just replaced the obsoleted if_watchdog interface in ndis(4) with a
> local implementation. This should remove the obnoxious warning message
> on device init. Anyone using -CURRENT with an ndis card, could you send
> me success/fails?
> 
> The patch is here:
>   * http://people.freebsd.org/~cokane/patches/if_ndis-new_wd.patch


This works different to the rest of the network drivers. The existing
drivers use a callout tick that runs while the driver is up and an
integer counter.

 if (x && --x == 0)
	 ...timeout...

You arm the callout and stop it after each Tx, does this have any
perfornace impact?


Andrew