Date: Mon, 12 Jan 2015 17:42:34 +0000 From: "Bjoern A. Zeeb" <bz@FreeBSD.org> To: John Baldwin <john@baldwin.cx> Cc: "src-committers@freebsd.org" <src-committers@freebsd.org>, John Nielsen <lists@jnielsen.net>, Bryan Venteicher <bryanv@freebsd.org>, "svn-src-all@freebsd.org" <svn-src-all@freebsd.org>, Bryan Drewery <bdrewery@freebsd.org>, "svn-src-head@freebsd.org" <svn-src-head@freebsd.org> Subject: Re: svn commit: r272886 - in head/sys: netinet netinet6 Message-ID: <88ADFC71-FD44-4012-9814-1771D31646FF@FreeBSD.org> In-Reply-To: <6173473.uE5Sr5nj0c@ralph.baldwin.cx> References: <201410100609.s9A690NU067686@svn.freebsd.org> <54AC6F4E.1000707@FreeBSD.org> <CAGaYwLezj6J8AJKFo9wbw3Z-gf8=ip418E%2BvPqr09AZ3f7hsbQ@mail.gmail.com> <6173473.uE5Sr5nj0c@ralph.baldwin.cx>
next in thread | previous in thread | raw e-mail | index | archive | help
> On 12 Jan 2015, at 15:51 , John Baldwin <john@baldwin.cx> wrote: >=20 > On Tuesday, January 06, 2015 07:07:11 PM Bryan Venteicher wrote: >> On Tue, Jan 6, 2015 at 5:27 PM, Bryan Drewery <bdrewery@freebsd.org> = wrote: >>> On 1/6/2015 4:00 PM, Bryan Venteicher wrote: >>>> On Tue, Jan 6, 2015 at 2:52 PM, John Nielsen <lists@jnielsen.net >>>>=20 >>>> <mailto:lists@jnielsen.net>> wrote: >>>> Bryan- >>>>=20 >>>> On Oct 10, 2014, at 12:09 AM, Bryan Venteicher = <bryanv@freebsd.org >>>>=20 >>>> <mailto:bryanv@freebsd.org>> wrote: >>>>> Author: bryanv >>>>> Date: Fri Oct 10 06:08:59 2014 >>>>> New Revision: 272886 >>>>> URL: https://svnweb.freebsd.org/changeset/base/272886 >>>>>=20 >>>>> Log: >>>>> Add context pointer and source address to the UDP tunnel callback >>>>>=20 >>>>> These are needed for the forthcoming vxlan implementation. The >>>=20 >>> context >>>=20 >>>>> pointer means we do not have to use a spare pointer field in the >>>=20 >>> inpcb, >>>=20 >>>>> and the source address is required to populate vxlan's forwarding >>>=20 >>> table. >>>=20 >>>>> While I highly doubt there is an out of tree consumer of the UDP >>>>> tunneling callback, this change may be a difficult to eventually >>>=20 >>> MFC. >>>=20 >>>> I noticed this comment while doing an MFC of vxlan to my local = tree. >>>> Do you think an MFC to 10-STABLE of this change (and vxlan >>>> generally) will be feasible? Is there precedent for ABI changes = like >>>> this being sanctioned? Could symbol versioning help? >>>>=20 >>>> I'd like to get some consensus on whether this commit is OK to MFC. = With >>>> this commit, vxlan should be an easy to MFC. >>>=20 >>> Breaking ABI will potentially hurt packages. FreeBSD builds packages = for >>> the oldest supported release on a branch. If you break ABI in 10.2 = while >>> we are building packages for 10.1 then any packages using these >>> interfaces may not work right or result in panics packages with = kmods. >>> Please consider that. >>=20 >> The only user visible change of this commit would be the addition of = a >> field at the end of 'struct udpcb'. I don't think that is a problem, = at >> least a similar change didn't prevent the MFC of UDP Lite. >>=20 >> The kernel part of this changes the UDP tunneling functions which I = guess >> there could be a 3rd party module out there, but I very highly doubt = that, >> based on how un-useful the previous interface was. >=20 > Userland should not be impacted by this at all. (Nothing in userland = cares > about udpcb's internals.) I think there was only ever one consumer = for the=20 > existing UDP tunneling code (bz@ knows what it is). I'm not sure = where it=20 > lives. If you are talking about u_tun_func then it came from SCTP over UDP = tunneling. tuexen and rrs are your friends. I was wondering if it could be used similarly for IPsec UDPencap but I = think that went nowhere back then. =E2=80=94=20 Bjoern A. Zeeb Charles Haddon Spurgeon: "Friendship is one of the sweetest joys of life. Many might have failed beneath the bitterness of their trial had they not found a friend."
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?88ADFC71-FD44-4012-9814-1771D31646FF>