From owner-cvs-src@FreeBSD.ORG Sat Aug 26 08:27:57 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.ORG Delivered-To: cvs-src@FreeBSD.ORG Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 2909F16A4DE; Sat, 26 Aug 2006 08:27:57 +0000 (UTC) (envelope-from wb@freebie.xs4all.nl) Received: from smtp-vbr10.xs4all.nl (smtp-vbr10.xs4all.nl [194.109.24.30]) by mx1.FreeBSD.org (Postfix) with ESMTP id 2496B43D45; Sat, 26 Aug 2006 08:27:55 +0000 (GMT) (envelope-from wb@freebie.xs4all.nl) Received: from freebie.xs4all.nl (freebie.xs4all.nl [213.84.32.253]) by smtp-vbr10.xs4all.nl (8.13.6/8.13.6) with ESMTP id k7Q8RqXN020576; Sat, 26 Aug 2006 10:27:53 +0200 (CEST) (envelope-from wb@freebie.xs4all.nl) Received: from freebie.xs4all.nl (localhost [127.0.0.1]) by freebie.xs4all.nl (8.13.6/8.13.3) with ESMTP id k7Q8RqlJ011958; Sat, 26 Aug 2006 10:27:52 +0200 (CEST) (envelope-from wb@freebie.xs4all.nl) Received: (from wb@localhost) by freebie.xs4all.nl (8.13.6/8.13.6/Submit) id k7Q8Rq6V011957; Sat, 26 Aug 2006 10:27:52 +0200 (CEST) (envelope-from wb) Date: Sat, 26 Aug 2006 10:27:52 +0200 From: Wilko Bulte To: Steve Kargl Message-ID: <20060826082751.GA11942@freebie.xs4all.nl> References: <200608240737.k7O7bDMC085424@repoman.freebsd.org> <20060824092002.44b90594@kan.dnsalias.net> <20060824133628.GA54467@gvr.gvr.org> <20060824101606.414e8bf6@kan.dnsalias.net> <20060824205854.GA59856@gvr.gvr.org> <20060824184402.2ee29d79@kan.dnsalias.net> <20060826020854.GD16768@turion.vk2pj.dyndns.org> <20060826023120.GA74468@troutmask.apl.washington.edu> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20060826023120.GA74468@troutmask.apl.washington.edu> User-Agent: Mutt/1.5.11 X-Virus-Scanned: by XS4ALL Virus Scanner Cc: src-committers@FreeBSD.ORG, Peter Jeremy , cvs-all@FreeBSD.ORG, cvs-src@FreeBSD.ORG, Guido van Rooij , Alexander Kabaev Subject: Re: cvs commit: src/contrib/ipfilter HISTORY Makefile bpf_filter.c ip_fil.c ipf.h ipmon.h ipt.h kmem.h mlfk_rule.c opts.h radix.c radix_ipf.h snoop.h src/contrib/ipfilter/BSD Makefile Makefile.ipsend kupgrade src/contrib/ipfilter/iplang iplang_l.l ... X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 26 Aug 2006 08:27:57 -0000 On Fri, Aug 25, 2006 at 07:31:20PM -0700, Steve Kargl wrote.. > On Sat, Aug 26, 2006 at 12:08:54PM +1000, Peter Jeremy wrote: > > On Thu, 2006-Aug-24 18:44:02 -0400, Alexander Kabaev wrote: > > >personally. The mistake you made just shows how important it is to do a > > >buildworld _from freshly checked out sources_ after every major vendor > > >import. > > > > I'm not sure how doing this would have prevented the breakage. It > > might have allowed Guido to notice the breakage more quickly. > > It would have caught the first problem, which I reported here > http://lists.freebsd.org/pipermail/freebsd-current/2006-August/065175.html. > This problem was fixed by kan as noted here > http://lists.freebsd.org/pipermail/cvs-src/2006-August/067536.html > > Notice I reported the problem of Aug 16th. Kan's patch was committed > on Aug 17th. > > > Guido made a mistake, has apologised and has corrected the problem in > > less than 6 hours. > > He only corrected the second problem caused by his commit. Can we please stop this moaning about Guido's work? Mistakes do get made, and in this case were fixed rapidly. Please move on, nothing here to see anymore. -- Wilko Bulte wilko@FreeBSD.org