From owner-freebsd-fs@freebsd.org Mon Feb 15 09:45:24 2021 Return-Path: Delivered-To: freebsd-fs@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 2A27754F91C; Mon, 15 Feb 2021 09:45:24 +0000 (UTC) (envelope-from avg@FreeBSD.org) Received: from relay1-d.mail.gandi.net (relay1-d.mail.gandi.net [217.70.183.193]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 4DfK374htYz3rWL; Mon, 15 Feb 2021 09:45:23 +0000 (UTC) (envelope-from avg@FreeBSD.org) X-Originating-IP: 195.64.148.76 Received: from [192.168.0.88] (unknown [195.64.148.76]) (Authenticated sender: andriy.gapon@uabsd.com) by relay1-d.mail.gandi.net (Postfix) with ESMTPSA id 8A94724000A; Mon, 15 Feb 2021 09:45:20 +0000 (UTC) Subject: Re: panic: condition seqc_in_modify(_vp->v_seqc) not met at zfs_acl.c:1147 (zfs_acl_chown_setattr) From: Andriy Gapon To: FreeBSD Current , freebsd-fs@FreeBSD.org References: <1b261679-3492-dda8-614e-21150a2375d8@FreeBSD.org> Message-ID: <038304d0-2cd0-f089-56ee-c094cdc4cc21@FreeBSD.org> Date: Mon, 15 Feb 2021 11:45:19 +0200 User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:78.0) Gecko/20100101 Firefox/78.0 Thunderbird/78.7.1 MIME-Version: 1.0 In-Reply-To: <1b261679-3492-dda8-614e-21150a2375d8@FreeBSD.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 4DfK374htYz3rWL X-Spamd-Bar: / Authentication-Results: mx1.freebsd.org; none X-Spamd-Result: default: False [0.00 / 15.00]; local_wl_from(0.00)[FreeBSD.org]; ASN(0.00)[asn:29169, ipnet:217.70.176.0/20, country:FR] X-BeenThere: freebsd-fs@freebsd.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Filesystems List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 15 Feb 2021 09:45:24 -0000 On 15/02/2021 10:22, Andriy Gapon wrote: > > I've got this panic once when copying a couple of files. > The system is stable/13 as of 1996360d7338d, a custom kernel configuration, but > no local source code modifications. > > Unread portion of the kernel message buffer: > VNASSERT failed: ({ seqc_t __seqc = (_vp->v_seqc); __builtin_expect((__seqc & > 1), 0); }) not true at > /usr/devel/git/trant/sys/contrib/openzfs/module/os/freebsd/zfs/zfs_acl.c:1147 > (zfs_acl_chown_setattr) > 0xfffff8013e4e85b8: type VDIR > usecount 1, writecount 0, refcount 1 seqc users 0 mountedhere 0 > hold count flags () > flags () > lock type zfs: EXCL by thread 0xfffffe01dd1cd560 (pid 30747, kdeinit5, tid > 159911) > panic: condition seqc_in_modify(_vp->v_seqc) not met at > /usr/devel/git/trant/sys/contrib/openzfs/module/os/freebsd/zfs/zfs_acl.c:1147 > (zfs_acl_chown_setattr) > > Any ideas, suggestions, hints? > Thanks! > ... > #4 0xffffffff8036fd21 in zfs_acl_chown_setattr (zp=0xfffff801ccd203b0) > at /usr/devel/git/trant/sys/contrib/openzfs/module/os/freebsd/zfs/zfs_acl.c:1147 > #5 0xffffffff8037e52d in zfs_setattr (zp=0xfffff8024b04f760, > vap=vap@entry=0xfffffe029a36c870, flags=flags@entry=0, > cr=, cr@entry=0xfffff8003ecedc00) > at > /usr/devel/git/trant/sys/contrib/openzfs/module/os/freebsd/zfs/zfs_vnops_os.c:2758 So, this is actually the second zfs_acl_chown_setattr call here: err = zfs_acl_chown_setattr(zp); ASSERT(err == 0); if (attrzp) { err = zfs_acl_chown_setattr(attrzp); ASSERT(err == 0); } I am not sure if the assertion is actually applicable to attrzp (extended attributes "directory"). At least I do not see any seq calls for it. -- Andriy Gapon