From owner-svn-src-all@FreeBSD.ORG Mon Aug 25 19:39:44 2014 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 9B960708; Mon, 25 Aug 2014 19:39:44 +0000 (UTC) Received: from bigwig.baldwin.cx (bigwig.baldwin.cx [IPv6:2001:470:1f11:75::1]) (using TLSv1 with cipher DHE-RSA-CAMELLIA256-SHA (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 6E02D3369; Mon, 25 Aug 2014 19:39:44 +0000 (UTC) Received: from ralph.baldwin.cx (pool-173-70-85-31.nwrknj.fios.verizon.net [173.70.85.31]) by bigwig.baldwin.cx (Postfix) with ESMTPSA id 3B264B987; Mon, 25 Aug 2014 15:39:43 -0400 (EDT) From: John Baldwin To: Bryan Drewery Subject: Re: svn commit: r270510 - head Date: Mon, 25 Aug 2014 15:17:52 -0400 Message-ID: <3014037.G9yExtHamp@ralph.baldwin.cx> User-Agent: KMail/4.10.5 (FreeBSD/10.0-STABLE; KDE/4.10.5; amd64; ; ) In-Reply-To: <53FB81E9.1010407@FreeBSD.org> References: <61DA1EC8-C938-4AB8-B518-7249307B4379@felyko.com> <53FB81E9.1010407@FreeBSD.org> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.2.7 (bigwig.baldwin.cx); Mon, 25 Aug 2014 15:39:43 -0400 (EDT) Cc: Benjamin Kaduk , "src-committers@freebsd.org" , peter@wemm.org, Don Lewis , Gleb Smirnoff , Rui Paulo , "svn-src-head@freebsd.org" , "svn-src-all@freebsd.org" X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 25 Aug 2014 19:39:44 -0000 On Monday, August 25, 2014 01:35:21 PM Bryan Drewery wrote: > On 8/25/2014 12:36 PM, Benjamin Kaduk wrote: > > On Mon, Aug 25, 2014 at 10:10 AM, Gleb Smirnoff > > > > wrote: > > And carrying this stuff costs us almost nothing. > > > > The cost of having it in the tree is small, yes. But the runtime cost > > when people actually run delete-old will only keep increasing ... it > > already feels kind of slow, to me. > > > > -Ben > > This could be fixed by not calling rm(1) for every file but instead > using xargs rm so it is called only a few times, when not needing -i. > The same goes for the chflags and -f/-L tests. It would be much more > manageable if all of the logic moved into a shell script. rm -i foo bar still prompts individually for each file, so presumably you could always use 'xargs | rm'? -- John Baldwin