Date: Mon, 9 Oct 2017 16:23:42 +0000 From: Alexey Dokuchaev <danfe@FreeBSD.org> To: Mathieu Arnold <mat@FreeBSD.org> Cc: Joe Marcus Clarke <marcus@FreeBSD.org>, ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r451553 - in head/ports-mgmt/portlint: . src Message-ID: <20171009162342.GA2723@FreeBSD.org> In-Reply-To: <e577bff2-63cf-7411-74e1-f587e4dee31f@FreeBSD.org> References: <201710081758.v98HwqIe003342@repo.freebsd.org> <e577bff2-63cf-7411-74e1-f587e4dee31f@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Mon, Oct 09, 2017 at 06:07:00PM +0200, Mathieu Arnold wrote: > Le 08/10/2017 ?? 19:58, Joe Marcus Clarke a ??crit : > > New Revision: 451553 > > URL: https://svnweb.freebsd.org/changeset/ports/451553 > > > > Log: > > Update to 2.17.13. > > > > * Do not complain about USE_GITHUB before USES [1] > > This is wrong. USES= must always happen before any other USE_* variable. Not really. GitHub-related knobs are often grouped together and put closer to the top because they are more related to obtaining the distfile (think MASTER_SITES) rather than the configuring/building/etc. steps of the software in question itself. Technically there's nothing wrong with any order prior to .include's of other Mk/* files, so this kind of grouping helps readability while not affecting anything else. ./danfe
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20171009162342.GA2723>