Date: Sat, 21 Aug 1999 06:56:38 -0500 (EST) From: "John S. Dyson" <dyson@iquest.net> To: dillon@apollo.backplane.com (Matthew Dillon) Cc: bright@rush.net (Alfred Perlstein), eivind@FreeBSD.ORG (Eivind Eklund), peter@FreeBSD.ORG (Peter Wemm), current@FreeBSD.ORG Subject: Re: NFS HEADS UP (was Re: cvs commit: src/sys/nfs nfsm_subs.h xdr_subs.h) Message-ID: <199908211156.GAA20231@dyson.iquest.net.> In-Reply-To: <199908191829.LAA57025@apollo.backplane.com> from Matthew Dillon at "Aug 19, 1999 11:29:31 am"
next in thread | previous in thread | raw e-mail | index | archive | help
Matthew Dillon said: > :> global references across subroutine calls! I'll send Luoqi another email. > :> > :> In the case of the NFS stuff, the changes have been pretty well tested > :> so I think we are in the clear. > : > :On a somewhat similar note, what do you think about converting a lot > :of the NFS macros to functions, yes i know it will be difficult, but > :there is so much forced inlining it just seems like it would reduce > :the codesize signifigantly and play nicer with the CPU cache. > : > :It would also make the code a lot more readable. > : > :Worthwhile exercise? > : > :-Alfred Perlstein - [bright@rush.net|bright@wintelcom.net] > > Well, the issue with converting many of the macros to inline functions > is with the embedded goto's and references to variables defined outside > the macros. Converting them to functions would basically require > rewriting a huge chunk of NFS code. > My working kernel runs with a few strategic NFS macros being converted to functions, and the size improvement is about 50K or so (maybe more!!!) John To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-current" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?199908211156.GAA20231>