From owner-freebsd-hackers Thu Feb 8 06:53:46 1996 Return-Path: owner-hackers Received: (from root@localhost) by freefall.freebsd.org (8.7.3/8.7.3) id GAA23470 for hackers-outgoing; Thu, 8 Feb 1996 06:53:46 -0800 (PST) Received: from tfs.com (tfs.com [140.145.250.1]) by freefall.freebsd.org (8.7.3/8.7.3) with SMTP id GAA23464 for ; Thu, 8 Feb 1996 06:53:45 -0800 (PST) Received: from critter.tfs.com by tfs.com (smail3.1.28.1) with SMTP id m0tkXjD-0003w4C; Thu, 8 Feb 96 06:53 PST Received: from localhost.tfs.com (localhost.tfs.com [127.0.0.1]) by critter.tfs.com (8.6.12/8.6.12) with SMTP id PAA00473; Thu, 8 Feb 1996 15:53:42 +0100 X-Authentication-Warning: critter.tfs.com: Host localhost.tfs.com didn't use HELO protocol To: Julian Elischer cc: hackers@freebsd.org Subject: Re: TERRY patches.. In-reply-to: Your message of "Wed, 07 Feb 1996 03:18:02 PST." <199602071118.DAA00521@ref.tfs.com> Date: Thu, 08 Feb 1996 15:53:42 +0100 Message-ID: <471.823791222@critter.tfs.com> From: Poul-Henning Kamp Sender: owner-hackers@freebsd.org Precedence: bulk > I like the namei/lookup addition of the EXCLUDE > flag. Seems good to me.. the moving of some functionality from filesystems > to common code is a good idea. yes, I like this part. > The reworking of mount() is ingenious, but I think we should not > impliment much of it. agree. > I think 'cosmetic reworks' should be avoided, as it tends to: > 1/ make it harder to merge/compare code > 2/ obfuscate the real nature of the change. agree. -- Poul-Henning Kamp | phk@FreeBSD.ORG FreeBSD Core-team. http://www.freebsd.org/~phk | phk@login.dknet.dk Private mailbox. whois: [PHK] | phk@ref.tfs.com TRW Financial Systems, Inc. Future will arrive by its own means, progress not so.