From owner-svn-src-head@FreeBSD.ORG Fri Feb 26 15:17:08 2010 Return-Path: Delivered-To: svn-src-head@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 2D4E7106566B; Fri, 26 Feb 2010 15:17:08 +0000 (UTC) (envelope-from imp@bsdimp.com) Received: from harmony.bsdimp.com (bsdimp.com [199.45.160.85]) by mx1.freebsd.org (Postfix) with ESMTP id D8F9E8FC2F; Fri, 26 Feb 2010 15:17:07 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by harmony.bsdimp.com (8.14.3/8.14.1) with ESMTP id o1QF3sYs098131; Fri, 26 Feb 2010 08:03:54 -0700 (MST) (envelope-from imp@bsdimp.com) Date: Fri, 26 Feb 2010 08:04:02 -0700 (MST) Message-Id: <20100226.080402.506212773199817375.imp@bsdimp.com> To: attilio@freebsd.org From: "M. Warner Losh" In-Reply-To: <3bbf2fe11002260557y484cf13bq76f7507c07ed3ebc@mail.gmail.com> References: <20100226104936.GD2489@deviant.kiev.zoral.com.ua> <20100226132854.GA25722@sandvine.com> <3bbf2fe11002260557y484cf13bq76f7507c07ed3ebc@mail.gmail.com> X-Mailer: Mew version 6.3 on Emacs 22.3 / Mule 5.0 (SAKAKI) Mime-Version: 1.0 Content-Type: Text/Plain; charset=iso-8859-1 Content-Transfer-Encoding: quoted-printable Cc: src-committers@freebsd.org, delphij@gmail.com, svn-src-all@freebsd.org, svn-src-head@freebsd.org, kostikbel@gmail.com, emaste@freebsd.org Subject: Re: svn commit: r204309 - in head/sys: amd64/amd64 amd64/isa conf i386/bios i386/cpufreq i386/i386 i386/isa i386/xen isa modules/bios/smbios modules/bios/vpd modules/cpufreq pc98/pc98 x86 x86/bios x86/... X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 26 Feb 2010 15:17:08 -0000 In message: <3bbf2fe11002260557y484cf13bq76f7507c07ed3ebc@mail.gmail.co= m> Attilio Rao writes: : 2010/2/26 Ed Maste : : > [ About the i386/amd64/pc98 -> x86 merge ] : > : >> > : I think there have been already MFCed patches doing headers mo= vements : >> > : in the past. : >> > : >> > We've tried to keep the KPI upwardly compatible. =A0If files mov= e, then : >> > old code will potentially break. : >> : >> Yes, but there is very non-trivial cost of not merging this. : >> It makes testing in HEAD of other patches less valuable for merges= , : >> and merges itself becomes more time-consuming and risking. : >> : >> Fortunately, I do not no dri, but I know that maintaining patches : >> both for 7 and 8/HEAD of dri is a hell. : > : > For headers on older branches we can just leave backwards compatibi= lity : > stubs in the i386, amd64 and pc98 directories that include the head= er : > from the new x86 directory. : = : Yes, I thought something along those lines, if we think it is worthy : (I'm not very concerned about it right now). : For the future, however, probabilly we would need to do something lik= e : pc98 already does wrt i386 (i386/include/ pc98/include/ amd64/include= / : just have files wrappers to the generic one under x86/include/ when : necessary). Yes. If you're going to merge this to old branches, it is critical that you do this so you don't break the compilation of modules on those branches. Warner