Skip site navigation (1)Skip section navigation (2)
Date:      Tue, 07 Jun 2016 12:35:05 +0000
From:      bugzilla-noreply@freebsd.org
To:        freebsd-ports-bugs@FreeBSD.org
Subject:   [Bug 209945] devel/jsoncpp: Does not build on 10.3 due to C++11 assumption on ppc64
Message-ID:  <bug-209945-13-0O2AFBAnl8@https.bugs.freebsd.org/bugzilla/>
In-Reply-To: <bug-209945-13@https.bugs.freebsd.org/bugzilla/>
References:  <bug-209945-13@https.bugs.freebsd.org/bugzilla/>

next in thread | previous in thread | raw e-mail | index | archive | help
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D209945

--- Comment #4 from Mathieu Simon <freebsd@simweb.ch> ---
Created attachment 171140
  --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=3D171140&action=
=3Dedit
Attemp to fix issues with older GCC version and C++11 enablement

Hi Vladimir

I think I may have something, it seems to compile on:
- 10.3-amd64 (clang)   -> Builds, with C++11    (expected, no regression)
- 9.3-amd64  (GCC 4.2) -> Builds, without C++11 (expected, no regression)
- 10.3-ppc64 (GCC 4.2) -> Builds, without C++11 (expected, now fixed)

With this patch the port checks if the compiler is recent enough, not the OS
type or OS version. This would have the added advantage of (quite likely)
allowing DragonFly folks to compile lang/jsoncpp with C++11 support too sin=
ce
they ship newer GCC versions in their base and use the FreeBSD ports tree.

The idea is based on what Mk/Uses/compiler.mk does and what I found in comp=
iler
checks such as in x11/eaglemode/Makefile.=20

I agree that this patch somewhat duplicates the efforts of compiler.mk. How=
ever
with this we still allow building on non-C++11 compilers as currently.

The versions required for C++11 support of both clang and GCC support was b=
ased
on for C++11 implementation status sites of each project:
- clang: http://clang.llvm.org/cxx_status.html
- GCC: https://gcc.gnu.org/projects/cxx-status.html#cxx11

Looking forward to your feedback.

-- Mathieu

--=20
You are receiving this mail because:
You are the assignee for the bug.=



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-209945-13-0O2AFBAnl8>