From owner-freebsd-ports@freebsd.org Thu Apr 20 20:29:46 2017 Return-Path: Delivered-To: freebsd-ports@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 92AA9D483F9 for ; Thu, 20 Apr 2017 20:29:46 +0000 (UTC) (envelope-from jev@ecadlabs.com) Received: from mail-qt0-x229.google.com (mail-qt0-x229.google.com [IPv6:2607:f8b0:400d:c0d::229]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4F55295E for ; Thu, 20 Apr 2017 20:29:46 +0000 (UTC) (envelope-from jev@ecadlabs.com) Received: by mail-qt0-x229.google.com with SMTP id m36so55312381qtb.0 for ; Thu, 20 Apr 2017 13:29:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ecadlabs.com; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to; bh=o9BOSjIDE/FfeAQhzFI/SqUUFKtKqj5K4UbAOdeRvvY=; b=MXm8XX1FG2yYu2uHFSwE0khApDvSkVIsUWSjoJafYenmDucbfQxQkOWS3ExjruB24U XevHlm0f/U/NwApwcoJF/2pBQn/akGVxnfvEZUj+vDAgO+EGfVx3G1fd9waH8ugV6GKT 8GYJUQix5hXAgLjhOhCP0M5JRmbRpbznbNp/9jQfnr5vSC5x5M07wOaBTeJA73HGMV+/ swUHZhT8FiDTaOpHYBL2OE7jqZ5C5LtLgFIeK5naucOFAzpsEF62ydOyt/GIcDXjx6uE F5vMX2CvC/eJVCHhOhghbMKYMQEfuJ4dDJTCXJ4t8jLKbgLGLoE5/Ybt1AgGYOwt6+RE Ji0A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to; bh=o9BOSjIDE/FfeAQhzFI/SqUUFKtKqj5K4UbAOdeRvvY=; b=Dfh0Pb7U7mKTzFE9uMrfzsgD7MdzGOuqyyip22980I9YlQkCpu6v4Bln/NA00fY206 sMihkRl/v8W4CrzKgEUeuC4Hl6robGMwwfW7/kNkLjXgPlSDt5GlpVGIl1WrPDPz2UJ7 DAQdWewzM0NERhRYXxAAt6x5Wh7o9+TcRVDbRBS8m0qcnqK2YzoKU2LVASx+gw1ReDd6 Iw3Xjdm3qDujt2rxJf3Gx8c0HKxX+l339kGU+/UPjcgG1NjcF2VLqCBtYe7+X68hCHDS 8WDiYpiU4fgEk9PUBKgoyLYREBVauoLzmpIZftKFUObxoHkn1p75DzMr5/wDT0j+S8k1 Dspw== X-Gm-Message-State: AN3rC/46kBJulW2RWWlaRGaVGm+Kd5Qb6P9ytbkXw8/XS6NV0tMoY0FK +y8jd5nqU+hhez8HY5gtf5G0f5iPFFZNfWQ= X-Received: by 10.200.34.162 with SMTP id f31mr10645990qta.65.1492720185332; Thu, 20 Apr 2017 13:29:45 -0700 (PDT) MIME-Version: 1.0 References: <11DAA44D-661F-4762-ABFD-78E4806D6E2E@lerctr.org> In-Reply-To: From: =?UTF-8?Q?Jev_Bj=C3=B6rsell?= Date: Thu, 20 Apr 2017 20:29:34 +0000 Message-ID: Subject: Re: net-mgmt/prometheus update to 1.6.0, comitter requested To: Larry Rosenman , "freebsd-ports@freebsd.org" Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Content-Filtered-By: Mailman/MimeDel 2.1.23 X-BeenThere: freebsd-ports@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Porting software to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 20 Apr 2017 20:29:46 -0000 Great, thank you! Any feedback on port structure is welcome by me :) -Jev On Thu, Apr 20, 2017 at 11:43 AM Larry Rosenman wrote: > Indeed. I=E2=80=99m working with my Mentor (adamw@, and swills@(of portm= gr@)) > and they had the issue with unknown. > > > > I=E2=80=99ll get this done. =E2=98=BA > > > > > > -- > > Larry Rosenman http://www.lerctr.org/~ler > > Phone: +1 214-642-9640 <(214)%20642-9640> E-Mail: > ler@lerctr.org > > US Mail: 17716 Limpia Crk, Round Rock, TX 78664-7281 > > > > > > > > *From: *Jev Bj=C3=B6rsell > *Date: *Thursday, April 20, 2017 at 1:39 PM > *To: *Larry Rosenman , "freebsd-ports@freebsd.org" < > freebsd-ports@freebsd.org> > *Subject: *Re: Re: net-mgmt/prometheus update to 1.6.0, comitter requeste= d > > > > Hi Larry, > > > > I presume you are referring the the strings 'unknown' that appear in the > do-build: portion of the Makefile. > > > > These are set to 'unknown' on purpose, because we do not have a way of > finding out that information unless we do it dynamically at build time. > Doing dynamically is not recommended for several reasons. > > > > This data gets displayed when a user runs `prometheus -version`, and most > of the fields are only really relevant to dev builds anyway. > > > > The crucial information is the software version number which is set. > > > > You can see me exchange on the subject in the ports mailing list archive > here: > > > > https://lists.freebsd.org/pipermail/freebsd-ports/2017-March/107833.html > > > > -Jev > > > > > > On Wed, Apr 19, 2017 at 9:23 PM ler wrote: > > Can you fill in the unknown stuff in the version package or should I just > go ahead and do it? > > > > On Apr 19, 2017 at 10:22 PM, > wrote= : > > Thanks Larry, > > > > I have updated the patch on the bug, because the upstream project has jus= t > released a minor version/bug fix release. New patch updates us to 1.6.1. > > > > Thanks, > > -Jev > > > > On Tue, Apr 18, 2017 at 1:22 PM Larry Rosenman wrote: > > On 4/18/17, 2:41 PM, "Jev Bj=C3=B6rsell" behalf of jev@ecadlabs.com> wrote: > > Hi All, > > Could I get a committer to apply my latest update patch for net-mg > mt/prometheus? > > Patch is available here: > https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D218737 > > Thanks so much, > -Jev > > Waiting for my mentor to approve. > > >