Skip site navigation (1)Skip section navigation (2)
Date:      Wed, 13 Dec 2006 07:50:40 GMT
From:      "Dr. Markus Waldeck"<waldeck@gmx.de>
To:        freebsd-gnats-submit@FreeBSD.org
Subject:   kern/106657: src/sys/netinet/udp_usrreq.c should contain a sufficient comment about net.inet.udp.checksum
Message-ID:  <200612130750.kBD7oe1M055122@www.freebsd.org>
Resent-Message-ID: <200612130800.kBD80J5K084467@freefall.freebsd.org>

next in thread | raw e-mail | index | archive | help

>Number:         106657
>Category:       kern
>Synopsis:       src/sys/netinet/udp_usrreq.c should contain a sufficient comment about net.inet.udp.checksum
>Confidential:   no
>Severity:       non-critical
>Priority:       medium
>Responsible:    freebsd-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          doc-bug
>Submitter-Id:   current-users
>Arrival-Date:   Wed Dec 13 08:00:18 GMT 2006
>Closed-Date:
>Last-Modified:
>Originator:     Dr. Markus Waldeck
>Release:        7.0-CURRENT-200611
>Organization:
>Environment:
FreeBSD fbh 7.0-CURRENT-200611 FreeBSD 7.0-CURRENT-200611
root@fb:/usr/src/sys/i386/compile/FB70B01 i386
>Description:
I tried to figure out what is the purpose of net.inet.udp.checksum.

I found in src/sys/netinet/udp_usrreq.c following lines

#ifndef	COMPAT_42
static int	udpcksum = 1;
#else
static int	udpcksum = 0;		/* XXX */
#endif

I expect that net.inet.udp.checksum is a 4.2BSD compatibility feature.

But /* XXX */ is NOT a very sufficient comment!
>How-To-Repeat:
less src/sys/netinet/udp_usrreq.c
>Fix:
add a useful comment
>Release-Note:
>Audit-Trail:
>Unformatted:



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200612130750.kBD7oe1M055122>