From owner-freebsd-hackers@freebsd.org Tue May 29 12:37:15 2018 Return-Path: Delivered-To: freebsd-hackers@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 4A5FCF790EA for ; Tue, 29 May 2018 12:37:15 +0000 (UTC) (envelope-from adhemerval.zanella@linaro.org) Received: from mail-qt0-x22d.google.com (mail-qt0-x22d.google.com [IPv6:2607:f8b0:400d:c0d::22d]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id C98B887A65 for ; Tue, 29 May 2018 12:37:14 +0000 (UTC) (envelope-from adhemerval.zanella@linaro.org) Received: by mail-qt0-x22d.google.com with SMTP id f13-v6so18350025qtp.10 for ; Tue, 29 May 2018 05:37:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=subject:to:cc:references:from:openpgp:autocrypt:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=MJ7c3ncMM7B8qCPiXJk4S72kYGDiamj8TF+C9W+kiNI=; b=A0X9tTQzyon4A+W5ynwR5Ch8n8JLNYBPH2euefqI1tYEk5zJ2fWHBBfxnh4BtJEjn6 zvoR+Q3TjA81YYoCypbgJom3qa/wiK1x1nQ16Viavo68Jj0zrkfyhl9Gdx+qW7QWdjL5 S5FhAcgY2w+tHKNB0ZIeTY26vM8QDtP+48KQw= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:openpgp:autocrypt :message-id:date:user-agent:mime-version:in-reply-to :content-language:content-transfer-encoding; bh=MJ7c3ncMM7B8qCPiXJk4S72kYGDiamj8TF+C9W+kiNI=; b=sUauOGi/B24eZMaIhHaCgIqLYH4esFXQVAJFsYpE479hYk+yKq5fwnuFWmrFeenGEf PPXld1UZXTEzPqd2H40+xfFOJmkL9W3iqdbFqAhyldq3gPmA9Wevn2EKeaK4OGM9UMsC mm160CqnxSsgOzBbaV01Zz3I7PKkBvG/rjoauFjN3xG49F0HTNd5/GP1j3CyRKn1XmSe WTfO2O+UR9FeAHjfowAyyY1ryFAWFlrpxNe0tZ9Cmv7kYJT8beXVMD9BRsxJB6qNwE2+ I0NRca+amWYswZ88zTPE29i1ZqBYrBWossowzpFeuSPSPbHXgUoe7aNZ5HW+K/+63M/j Zxlw== X-Gm-Message-State: ALKqPwcOhI02wMpSFSZjkVEgTyaKJj5A36OAP73Q3CaJ12PdaNdQ9EPA UjvcLrVpniEPK4ooVpr9kNfzsw== X-Google-Smtp-Source: ADUXVKJ5lFiVUUxPufG6K0jbvfM7ECBhKd+jobvXsJDQjiqzko6H7TjrB89BASTm1XVlci9EQ/2xUw== X-Received: by 2002:ac8:664c:: with SMTP id j12-v6mr16184646qtp.382.1527597434076; Tue, 29 May 2018 05:37:14 -0700 (PDT) Received: from [10.0.0.105] ([179.159.11.160]) by smtp.googlemail.com with ESMTPSA id v50-v6sm6105178qta.34.2018.05.29.05.37.11 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 29 May 2018 05:37:13 -0700 (PDT) Subject: Re: Code with apache-2 on /usr/src To: sgk@troutmask.apl.washington.edu Cc: Konstantin Belousov , freebsd-hackers@freebsd.org, emaste@freebsd.org References: <20180528190444.GE3789@kib.kiev.ua> <20180528193506.GA76705@troutmask.apl.washington.edu> <1c09023e-9bf5-d23a-dedc-1c4f4706bbde@linaro.org> <20180528202117.GA77184@troutmask.apl.washington.edu> <72101038-9e89-3f23-ab67-1c97b2a89803@linaro.org> <20180528210907.GA77475@troutmask.apl.washington.edu> <20180528221819.GA77894@troutmask.apl.washington.edu> From: Adhemerval Zanella Openpgp: preference=signencrypt Autocrypt: addr=adhemerval.zanella@linaro.org; prefer-encrypt=mutual; keydata= xsFNBFcVGkoBEADiQU2x/cBBmAVf5C2d1xgz6zCnlCefbqaflUBw4hB/bEME40QsrVzWZ5Nq 8kxkEczZzAOKkkvv4pRVLlLn/zDtFXhlcvQRJ3yFMGqzBjofucOrmdYkOGo0uCaoJKPT186L NWp53SACXguFJpnw4ODI64ziInzXQs/rUJqrFoVIlrPDmNv/LUv1OVPKz20ETjgfpg8MNwG6 iMizMefCl+RbtXbIEZ3TE/IaDT/jcOirjv96lBKrc/pAL0h/O71Kwbbp43fimW80GhjiaN2y WGByepnkAVP7FyNarhdDpJhoDmUk9yfwNuIuESaCQtfd3vgKKuo6grcKZ8bHy7IXX1XJj2X/ BgRVhVgMHAnDPFIkXtP+SiarkUaLjGzCz7XkUn4XAGDskBNfbizFqYUQCaL2FdbW3DeZqNIa nSzKAZK7Dm9+0VVSRZXP89w71Y7JUV56xL/PlOE+YKKFdEw+gQjQi0e+DZILAtFjJLoCrkEX w4LluMhYX/X8XP6/C3xW0yOZhvHYyn72sV4yJ1uyc/qz3OY32CRy+bwPzAMAkhdwcORA3JPb kPTlimhQqVgvca8m+MQ/JFZ6D+K7QPyvEv7bQ7M+IzFmTkOCwCJ3xqOD6GjX3aphk8Sr0dq3 4Awlf5xFDAG8dn8Uuutb7naGBd/fEv6t8dfkNyzj6yvc4jpVxwARAQABzUlBZGhlbWVydmFs IFphbmVsbGEgTmV0dG8gKExpbmFybyBWUE4gS2V5KSA8YWRoZW1lcnZhbC56YW5lbGxhQGxp bmFyby5vcmc+wsF3BBMBCAAhBQJXFRpKAhsDBQsJCAcDBRUKCQgLBRYCAwEAAh4BAheAAAoJ EKqx7BSnlIjv0e8P/1YOYoNkvJ+AJcNUaM5a2SA9oAKjSJ/M/EN4Id5Ow41ZJS4lUA0apSXW NjQg3VeVc2RiHab2LIB4MxdJhaWTuzfLkYnBeoy4u6njYcaoSwf3g9dSsvsl3mhtuzm6aXFH /Qsauav77enJh99tI4T+58rp0EuLhDsQbnBic/ukYNv7sQV8dy9KxA54yLnYUFqH6pfH8Lly sTVAMyi5Fg5O5/hVV+Z0Kpr+ZocC1YFJkTsNLAW5EIYSP9ftniqaVsim7MNmodv/zqK0IyDB GLLH1kjhvb5+6ySGlWbMTomt/or/uvMgulz0bRS+LUyOmlfXDdT+t38VPKBBVwFMarNuREU2 69M3a3jdTfScboDd2ck1u7l+QbaGoHZQ8ZNUrzgObltjohiIsazqkgYDQzXIMrD9H19E+8fw kCNUlXxjEgH/Kg8DlpoYJXSJCX0fjMWfXywL6ZXc2xyG/hbl5hvsLNmqDpLpc1CfKcA0BkK+ k8R57fr91mTCppSwwKJYO9T+8J+o4ho/CJnK/jBy1pWKMYJPvvrpdBCWq3MfzVpXYdahRKHI ypk8m4QlRlbOXWJ3TDd/SKNfSSrWgwRSg7XCjSlR7PNzNFXTULLB34sZhjrN6Q8NQZsZnMNs TX8nlGOVrKolnQPjKCLwCyu8PhllU8OwbSMKskcD1PSkG6h3r0AqzsFNBFcVGkoBEACgAdbR Ck+fsfOVwT8zowMiL3l9a2DP3Eeak23ifdZG+8Avb/SImpv0UMSbRfnw/N81IWwlbjkjbGTu oT37iZHLRwYUFmA8fZX0wNDNKQUUTjN6XalJmvhdz9l71H3WnE0wneEM5ahu5V1L1utUWTyh VUwzX1lwJeV3vyrNgI1kYOaeuNVvq7npNR6t6XxEpqPsNc6O77I12XELic2+36YibyqlTJIQ V1SZEbIy26AbC2zH9WqaKyGyQnr/IPbTJ2Lv0dM3RaXoVf+CeK7gB2B+w1hZummD21c1Laua +VIMPCUQ+EM8W9EtX+0iJXxI+wsztLT6vltQcm+5Q7tY+HFUucizJkAOAz98YFucwKefbkTp eKvCfCwiM1bGatZEFFKIlvJ2QNMQNiUrqJBlW9nZp/k7pbG3oStOjvawD9ZbP9e0fnlWJIsj 6c7pX354Yi7kxIk/6gREidHLLqEb/otuwt1aoMPg97iUgDV5mlNef77lWE8vxmlY0FBWIXuZ yv0XYxf1WF6dRizwFFbxvUZzIJp3spAao7jLsQj1DbD2s5+S1BW09A0mI/1DjB6EhNN+4bDB SJCOv/ReK3tFJXuj/HbyDrOdoMt8aIFbe7YFLEExHpSk+HgN05Lg5TyTro8oW7TSMTk+8a5M kzaH4UGXTTBDP/g5cfL3RFPl79ubXwARAQABwsFfBBgBCAAJBQJXFRpKAhsMAAoJEKqx7BSn lIjvI/8P/jg0jl4Tbvg3B5kT6PxJOXHYu9OoyaHLcay6Cd+ZrOd1VQQCbOcgLFbf4Yr+rE9l mYsY67AUgq2QKmVVbn9pjvGsEaz8UmfDnz5epUhDxC6yRRvY4hreMXZhPZ1pbMa6A0a/WOSt AgFj5V6Z4dXGTM/lNManr0HjXxbUYv2WfbNt3/07Db9T+GZkpUotC6iknsTA4rJi6u2ls0W9 1UIvW4o01vb4nZRCj4rni0g6eWoQCGoVDk/xFfy7ZliR5B+3Z3EWRJcQskip/QAHjbLa3pml xAZ484fVxgeESOoaeC9TiBIp0NfH8akWOI0HpBCiBD5xaCTvR7ujUWMvhsX2n881r/hNlR9g fcE6q00qHSPAEgGr1bnFv74/1vbKtjeXLCcRKk3Ulw0bY1OoDxWQr86T2fZGJ/HIZuVVBf3+ gaYJF92GXFynHnea14nFFuFgOni0Mi1zDxYH/8yGGBXvo14KWd8JOW0NJPaCDFJkdS5hu0VY 7vJwKcyHJGxsCLU+Et0mryX8qZwqibJIzu7kUJQdQDljbRPDFd/xmGUFCQiQAncSilYOcxNU EMVCXPAQTteqkvA+gNqSaK1NM9tY0eQ4iJpo+aoX8HAcn4sZzt2pfUB9vQMTBJ2d4+m/qO6+ cFTAceXmIoFsN8+gFN3i8Is3u12u8xGudcBPvpoy4OoG X-Enigmail-Draft-Status: N11100 Message-ID: <05943b3c-e2c6-4c03-93d9-5c2553e5865a@linaro.org> Date: Tue, 29 May 2018 09:37:07 -0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.8.0 MIME-Version: 1.0 In-Reply-To: <20180528221819.GA77894@troutmask.apl.washington.edu> Content-Type: text/plain; charset=utf-8 Content-Language: en-GB Content-Transfer-Encoding: 8bit X-BeenThere: freebsd-hackers@freebsd.org X-Mailman-Version: 2.1.26 Precedence: list List-Id: Technical Discussions relating to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 29 May 2018 12:37:15 -0000 On 28/05/2018 19:18, Steve Kargl wrote: > On Mon, May 28, 2018 at 06:12:13PM -0300, Adhemerval Zanella wrote: >> >>>> And is having a different algorithm for single and double prevision >>>> a blocker for a future patch proposal? >>> >>> No. Given the comment in sinf.c that max ULP is 0.56072, I do note that >>> the current implementation of sinf in lib/msun is more accurate (for >>> interesting values of x). I also looked at single/s_sincosf.c. It is >>> rather dubious to have 80+ digit numerical constants for a float, which >>> at most has 9 relevant digits. >>> >> >> Also keep in mind my initial idea is to propose patches only to expf, powf, >> logf, expf2, and log2f. > > OK, so I peeked at expf. Comment claims max ulp of 0.502. > Exhaustive testing for normal numbers in relevent range for > the current implementation of expf(x) shows > > Interval tested: [-18,88.72] > ULP: 0.90951, x = -5.19804668e+00f, /* 0xc0a65666 */ > flt = 5.52735012e-03f, /* 0x3bb51ec6 */ > dbl = 5.5273505437686398e-03, /* 0x3f76a3d8, 0xdd1aae8e */ > > But, then one looks at implementation details. msun's current > implementation is written in terms of single precision; while > the routine you're suggesting is written in terms of double_t. > So, achieving 0.502 ULP is due to having 53-bits in intermediate > results. It appears that the algorithm of the suggested code > cannot easily be generalized to double and long double without > implementing a multiple-precision routines. This is indeed true for the default implementation, although the same repo has alternative implementation that uses only float for expf, powf, and logf. However, as far as I could evaluated, the optimized expf and powf single version does not yield any gain over current FreeBSD version, only for the logf I see some gains. Do you see any issue about current approach of using intermediary double_t for internal calculations? > > Note, years ago, I submitted implementations for expf, exp, > ld80/expl, ld128/expl, logf, log, ld80/logl, and ld128/logl > based on papers by PTP Tang [1,2]. My versions for single > and double precision were not adopted even though these had > better accuracy. Either Bruce Evans improved or with Bruce's > help I improved the ld80 and ld128 routines, which were added > to msun. I know Bruce fixed minor issues with the single > and double precision routines, but he has not submitted patches. > > 1. PTP Tang, "Table-driven implementation of the exponential > function in IEEE floating-point arithmetic," ACM Trans. Math. > Soft., 15, 144-157 (1989). > > 2. PTP Tang, "Table-driven implementation of the logarithm > function in IEEE floating-point arithmetic," ACM Trans. Math. > Soft., 16, 378-400 (1990). > Thanks for the links, do you recall why exactly your implementations were not adopted? Do you think a similar proposal based on the arm repo would be also rejected?