From owner-freebsd-current@FreeBSD.ORG Wed Jul 15 10:51:18 2009 Return-Path: Delivered-To: current@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 4944D106566B for ; Wed, 15 Jul 2009 10:51:18 +0000 (UTC) (envelope-from rdivacky@vlk.vlakno.cz) Received: from vlakno.cz (77-93-215-190.static.masterinter.net [77.93.215.190]) by mx1.freebsd.org (Postfix) with ESMTP id 028238FC20 for ; Wed, 15 Jul 2009 10:51:17 +0000 (UTC) (envelope-from rdivacky@vlk.vlakno.cz) Received: from localhost (localhost [127.0.0.1]) by vlakno.cz (Postfix) with ESMTP id 9DF2A9CB0FA for ; Wed, 15 Jul 2009 12:49:37 +0200 (CEST) X-Virus-Scanned: amavisd-new at vlakno.cz Received: from vlakno.cz ([127.0.0.1]) by localhost (lev.vlakno.cz [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id xxehULVdnShn for ; Wed, 15 Jul 2009 12:49:35 +0200 (CEST) Received: from vlk.vlakno.cz (localhost [127.0.0.1]) by vlakno.cz (Postfix) with ESMTP id 1D0E29CB24F for ; Wed, 15 Jul 2009 12:49:35 +0200 (CEST) Received: (from rdivacky@localhost) by vlk.vlakno.cz (8.14.3/8.14.3/Submit) id n6FAnZvM060427 for current@freebsd.org; Wed, 15 Jul 2009 12:49:35 +0200 (CEST) (envelope-from rdivacky) Date: Wed, 15 Jul 2009 12:49:35 +0200 From: Roman Divacky To: current@freebsd.org Message-ID: <20090715104934.GA58659@freebsd.org> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="5mCyUwZo2JvN/JJP" Content-Disposition: inline User-Agent: Mutt/1.4.2.3i Cc: Subject: ppc(4) locking of isa_dma* X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 15 Jul 2009 10:51:18 -0000 --5mCyUwZo2JvN/JJP Content-Type: text/plain; charset=us-ascii Content-Disposition: inline hi the isa_dma* functions seem to require Giant. ppc(4) uses those but does not seem to lock Giant or anything. is this ok? is it a bug? I looked at the i386/isa/isa_dma.c and it seems pretty selfcontained (ie. it operates on hw and it's own variables). would it be sufficient to just introduce a new lock and lock with it all the isa_dma* functions ? or is there some indirect dependency on Giant that I cant see? there are not many users of this (most prominently fdc/ppc/sound-isa and some minor stuff). can someone comment? thnx! roman --5mCyUwZo2JvN/JJP Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.12 (FreeBSD) iEYEARECAAYFAkpdtD4ACgkQLVEj6D3CBEwQgQCeI6iXRj+OFKRw8iQcIZNJcCJo dycAn16P40eg46Y/ZxJT2YOQONuyAjPe =fKKJ -----END PGP SIGNATURE----- --5mCyUwZo2JvN/JJP--