From owner-cvs-all Thu Oct 26 8:48: 0 2000 Delivered-To: cvs-all@freebsd.org Received: from hand.dotat.at (hand.dotat.at [212.240.134.135]) by hub.freebsd.org (Postfix) with ESMTP id E83F237B479; Thu, 26 Oct 2000 08:47:55 -0700 (PDT) Received: from fanf by hand.dotat.at with local (Exim 3.15 #3) id 13odlb-00019o-00; Thu, 26 Oct 2000 03:31:47 +0000 Date: Thu, 26 Oct 2000 03:31:47 +0000 From: Tony Finch To: Matt Jacob Cc: cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/pci isp_pci.c Message-ID: <20001026033147.B4137@hand.dotat.at> References: <200010250440.VAA41157@freefall.freebsd.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.2i In-Reply-To: <200010250440.VAA41157@freefall.freebsd.org> Organization: Covalent Technologies, Inc Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.ORG Matt Jacob wrote: > > Whoops! Forgot to commit this when I committed the other (turnin on locks) > change. Sorry about that. It seems to me (based on my experience as an Apache core team member and as someone who likes to understand software by looking at how it evolved) that for the purposes of maintaining a useful history, cockups like this should be handled by using the same commit message when committing the missing file(s) as was used in the original commit. Apologies should be posted separately or as an extra note added to the original commit message, instead of replacing all useful information with "whoops, sorry". Tony. -- en oeccget g mtcaa f.a.n.finch v spdlkishrhtewe y dot@dotat.at eatp o v eiti i d. fanf@covalent.net To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message