From owner-svn-src-head@freebsd.org Wed May 22 04:25:26 2019 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 50628159EE2D; Wed, 22 May 2019 04:25:26 +0000 (UTC) (envelope-from freebsd@gndrsh.dnsmgr.net) Received: from gndrsh.dnsmgr.net (br1.CN84in.dnsmgr.net [69.59.192.140]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id B1D5F6A510; Wed, 22 May 2019 04:25:25 +0000 (UTC) (envelope-from freebsd@gndrsh.dnsmgr.net) Received: from gndrsh.dnsmgr.net (localhost [127.0.0.1]) by gndrsh.dnsmgr.net (8.13.3/8.13.3) with ESMTP id x4M4PNSK082700; Tue, 21 May 2019 21:25:23 -0700 (PDT) (envelope-from freebsd@gndrsh.dnsmgr.net) Received: (from freebsd@localhost) by gndrsh.dnsmgr.net (8.13.3/8.13.3/Submit) id x4M4PNCB082699; Tue, 21 May 2019 21:25:23 -0700 (PDT) (envelope-from freebsd) From: "Rodney W. Grimes" Message-Id: <201905220425.x4M4PNCB082699@gndrsh.dnsmgr.net> Subject: Re: svn commit: r348090 - in head/libexec/bootpd: . bootpgw In-Reply-To: <201905220413.x4M4DvBm057783@repo.freebsd.org> To: Mark Johnston Date: Tue, 21 May 2019 21:25:23 -0700 (PDT) CC: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Reply-To: rgrimes@freebsd.org X-Mailer: ELM [version 2.4ME+ PL121h (25)] MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset=US-ASCII X-Rspamd-Queue-Id: B1D5F6A510 X-Spamd-Bar: ------ Authentication-Results: mx1.freebsd.org X-Spamd-Result: default: False [-6.94 / 15.00]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; NEURAL_HAM_SHORT(-0.94)[-0.936,0]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; REPLY(-4.00)[] X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 22 May 2019 04:25:26 -0000 > Author: markj > Date: Wed May 22 04:13:57 2019 > New Revision: 348090 > URL: https://svnweb.freebsd.org/changeset/base/348090 > > Log: > Marginally improve usage() message style in bootpd. > > - Remove an extra space after "usage:". > - Avoid lines exceeding 80 columns. > > Based on notes from rgrimes. Thanks, but you missed an important aspect of those notes, see inline below. > > MFC with: r348066 > Event: Waterloo Hackathon 2019 > > Modified: > head/libexec/bootpd/bootpd.c > head/libexec/bootpd/bootpgw/bootpgw.c > > Modified: head/libexec/bootpd/bootpd.c > ============================================================================== > --- head/libexec/bootpd/bootpd.c Wed May 22 04:10:24 2019 (r348089) > +++ head/libexec/bootpd/bootpd.c Wed May 22 04:13:57 2019 (r348090) > @@ -587,8 +587,8 @@ PRIVATE void > usage() > { > fprintf(stderr, > - "usage: bootpd [-a] [-i | -s] [-c chdir-path] [-d level] [-h hostname] [-t timeout]\n"); > - fprintf(stderr, " [bootptab [dumpfile]]\n"); > + "usage: bootpd [-a] [-i | -s] [-c chdir-path] [-d level] [-h hostname]\n" > + " [-t timeout] [bootptab [dumpfile]]\n"); > fprintf(stderr, "\t -a\tdon't modify ARP table\n"); > fprintf(stderr, "\t -c n\tset current directory\n"); > fprintf(stderr, "\t -d n\tset debug level\n"); These 3 printf's are now miss aligned and contain a \t that should not be there: there may be more, I am only look at what is in context here. - fprintf(stderr, "\t -a\tdon't modify ARP table\n"); - fprintf(stderr, "\t -c n\tset current directory\n"); - fprintf(stderr, "\t -d n\tset debug level\n"); + fprintf(stderr, " -a\tdon't modify ARP table\n"); + fprintf(stderr, " -c n\tset current directory\n"); + fprintf(stderr, " -d n\tset debug level\n"); Regards, Rod > Modified: head/libexec/bootpd/bootpgw/bootpgw.c > ============================================================================== > --- head/libexec/bootpd/bootpgw/bootpgw.c Wed May 22 04:10:24 2019 (r348089) > +++ head/libexec/bootpd/bootpgw/bootpgw.c Wed May 22 04:13:57 2019 (r348090) > @@ -500,7 +500,8 @@ static void > usage() > { > fprintf(stderr, > - "usage: \nbootpgw [-a] [-d level] [-h count] [-i] [-s] [-t timeout] [-w time] server\n"); > + "usage: bootpgw [-a] [-i | -s] [-d level] [-h count] [-t timeout]\n" > + " [-w time] server\n"); > fprintf(stderr, "\t -a\tdon't modify ARP table\n"); > fprintf(stderr, "\t -d n\tset debug level\n"); > fprintf(stderr, "\t -h n\tset max hop count\n"); Same comments as above -- Rod Grimes rgrimes@freebsd.org