From owner-freebsd-ports@FreeBSD.ORG Fri Jun 1 10:31:57 2007 Return-Path: X-Original-To: ports@freebsd.org Delivered-To: freebsd-ports@FreeBSD.ORG Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 3508516A400 for ; Fri, 1 Jun 2007 10:31:57 +0000 (UTC) (envelope-from spreng@socket.ch) Received: from mailhub-lb1.unibe.ch (mailhub-lb1.unibe.ch [130.92.0.82]) by mx1.freebsd.org (Postfix) with ESMTP id C062C13C43E for ; Fri, 1 Jun 2007 10:31:56 +0000 (UTC) (envelope-from spreng@socket.ch) Received: from localhost (scanhub-lb3.unibe.ch [130.92.5.67]) by mailhub-lb1.unibe.ch (Postfix) with ESMTP id E445C11C077; Fri, 1 Jun 2007 12:13:40 +0200 (CEST) X-Virus-checked: by University of Bern Received: from mailhub-lb1.unibe.ch ([130.92.0.82]) by localhost (scanhub-lb3.unibe.ch [130.92.5.67]) (amavisd-new, port 10024) with LMTP id tVP3dawWGgDm; Fri, 1 Jun 2007 12:13:37 +0200 (CEST) Received: from hotpot (hotpot.unibe.ch [130.92.7.70]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mailhub-lb1.unibe.ch (Postfix) with ESMTP id EC96D11C08F; Fri, 1 Jun 2007 12:13:32 +0200 (CEST) Received: from yukon.unibe.ch (yukon.unibe.ch [130.92.7.23]) by hotpot (Postfix) with ESMTP id A60B414A40A8; Fri, 1 Jun 2007 12:13:32 +0200 (CEST) Message-ID: <465FF14C.8090205@socket.ch> Date: Fri, 01 Jun 2007 12:13:32 +0200 From: Thomas Spreng User-Agent: Thunderbird 2.0.0.0 (Macintosh/20070326) MIME-Version: 1.0 To: "Max N. Boyarov" References: <863b1lnurb.fsf@bsd.by> <86y7jdmedl.fsf@bsd.by> In-Reply-To: <86y7jdmedl.fsf@bsd.by> Content-Type: multipart/mixed; boundary="------------060300060704010706050002" Cc: ports@freebsd.org Subject: Re: net/rdesktop segfault X-BeenThere: freebsd-ports@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: spreng@socket.ch List-Id: Porting software to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 01 Jun 2007 10:31:57 -0000 This is a multi-part message in MIME format. --------------060300060704010706050002 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Hi, > after clean install xorg7.2 rdesktop segfault at login. same problem here, after upgrading xorg to v7.2 rdesktop segfaults on each login attempt. This seems to be a known problem with rdesktop. Based on a PR from Ubuntu, I've created a patch which should resolve this problem (see attachment). I'll send it in as a PR tonight. PS: apply with (cd /usr/ports/net/rdesktop && patch -p1 < /path/to/patch) PPS: forgot to cc: to list. cheers, tom. --------------060300060704010706050002 Content-Type: text/plain; x-mac-type="0"; x-mac-creator="0"; name="rdesktop-1.5.0_2.diff" Content-Transfer-Encoding: 7bit Content-Disposition: inline; filename="rdesktop-1.5.0_2.diff" diff -ruN rdesktop.bak/Makefile rdesktop/Makefile --- rdesktop.bak/Makefile Sat May 19 22:18:54 2007 +++ rdesktop/Makefile Fri Jun 1 11:30:39 2007 @@ -7,7 +7,7 @@ PORTNAME= rdesktop PORTVERSION= 1.5.0 -PORTREVISION?= 1 +PORTREVISION?= 2 CATEGORIES= net comms MASTER_SITES= ${MASTER_SITE_SOURCEFORGE} MASTER_SITE_SUBDIR= ${PORTNAME} diff -ruN rdesktop.bak/files/patch-xwin.c rdesktop/files/patch-xwin.c --- rdesktop.bak/files/patch-xwin.c Thu Jan 1 01:00:00 1970 +++ rdesktop/files/patch-xwin.c Fri Jun 1 11:30:39 2007 @@ -0,0 +1,11 @@ +--- xwin.c.orig Fri Jun 1 10:27:15 2007 ++++ xwin.c Fri Jun 1 10:28:26 2007 +@@ -3219,7 +3219,7 @@ + return; + + image = XCreateImage(g_display, g_visual, g_depth, ZPixmap, 0, +- (char *) data, cx, cy, BitmapPad(g_display), cx * g_bpp / 8); ++ (char *) data, cx, cy, g_bpp, 0); + + if (g_ownbackstore) + { --------------060300060704010706050002--