From owner-freebsd-ports-bugs@FreeBSD.ORG Mon Feb 1 18:40:02 2010 Return-Path: Delivered-To: freebsd-ports-bugs@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 0459C1065679 for ; Mon, 1 Feb 2010 18:40:02 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id B80B08FC0A for ; Mon, 1 Feb 2010 18:40:01 +0000 (UTC) Received: from freefall.freebsd.org (localhost [127.0.0.1]) by freefall.freebsd.org (8.14.3/8.14.3) with ESMTP id o11Ie1Ln073046 for ; Mon, 1 Feb 2010 18:40:01 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.3/8.14.3/Submit) id o11Ie1uc073045; Mon, 1 Feb 2010 18:40:01 GMT (envelope-from gnats) Resent-Date: Mon, 1 Feb 2010 18:40:01 GMT Resent-Message-Id: <201002011840.o11Ie1uc073045@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-ports-bugs@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, Darren Pilgrim Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 92626106568D for ; Mon, 1 Feb 2010 18:34:50 +0000 (UTC) (envelope-from nobody@FreeBSD.org) Received: from www.freebsd.org (www.freebsd.org [IPv6:2001:4f8:fff6::21]) by mx1.freebsd.org (Postfix) with ESMTP id 80FE88FC19 for ; Mon, 1 Feb 2010 18:34:50 +0000 (UTC) Received: from www.freebsd.org (localhost [127.0.0.1]) by www.freebsd.org (8.14.3/8.14.3) with ESMTP id o11IYol4099181 for ; Mon, 1 Feb 2010 18:34:50 GMT (envelope-from nobody@www.freebsd.org) Received: (from nobody@localhost) by www.freebsd.org (8.14.3/8.14.3/Submit) id o11IYoQr099180; Mon, 1 Feb 2010 18:34:50 GMT (envelope-from nobody) Message-Id: <201002011834.o11IYoQr099180@www.freebsd.org> Date: Mon, 1 Feb 2010 18:34:50 GMT From: Darren Pilgrim To: freebsd-gnats-submit@FreeBSD.org X-Send-Pr-Version: www-3.1 Cc: Subject: ports/143447: [patch] fix ports/mail/squirrelmail/bsd.squirrelmail.mk to not override USE_PHP set in plugin Makefiles X-BeenThere: freebsd-ports-bugs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Ports bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 01 Feb 2010 18:40:02 -0000 >Number: 143447 >Category: ports >Synopsis: [patch] fix ports/mail/squirrelmail/bsd.squirrelmail.mk to not override USE_PHP set in plugin Makefiles >Confidential: no >Severity: serious >Priority: medium >Responsible: freebsd-ports-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: sw-bug >Submitter-Id: current-users >Arrival-Date: Mon Feb 01 18:40:01 UTC 2010 >Closed-Date: >Last-Modified: >Originator: Darren Pilgrim >Release: 7.2 >Organization: >Environment: FreeBSD [redacted] 7.2-RELEASE-p1-jc2 FreeBSD 7.2-RELEASE-p1-jc2 #0: Thu Jun 18 15:16:49 PDT 2009 user@jail8.johncompanies.com:/usr/obj/usr/src/sys/jail8 amd64 >Description: The bsd.squirrelmail.mk is a Makefile include used by squirrelmail-plugin ports which provides common routines for correctly installing and activating plugins. The include file sets USE_PHP=yes unconditionally. If a plugin requires PHP extensions, this setting overrides any USE_PHP setting (e.g., USE_PHP=xmlrpc) in the plugin Makefile. >How-To-Repeat: 1. Create a Makefile that sets USE_PHP to something other than yes; 2. Run make -V USE_PHP and observe your setting; 3. Modify the Makefile to include ${PORTSDIR}/mail/squirrelmail/bsd.squirrelmail.mk after your USE_PHP setting; 4. Run make -V USE_PHP again and observe USE_PHP is now set to "yes" instead of your setting; >Fix: Modify bsd.squirrelmail.mk to set USE_PHP only if unset (i.e., ?= operator). The attached patch does exactly this. Patch attached with submission follows: --- bsd.squirrelmail.mk.orig 2010-01-14 19:16:29.000000000 -0800 +++ bsd.squirrelmail.mk 2010-01-31 15:18:00.000000000 -0800 @@ -27,7 +27,7 @@ NO_BUILD= yes NO_WRKSUBDIR= yes -USE_PHP= yes +USE_PHP?= yes WANT_PHP_WEB= yes SQUIRREL_PLUGIN_NAME?= ${PORTNAME} >Release-Note: >Audit-Trail: >Unformatted: