From owner-freebsd-ports-bugs@FreeBSD.ORG Thu Dec 22 14:10:11 2011 Return-Path: Delivered-To: freebsd-ports-bugs@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id CA54B1065679 for ; Thu, 22 Dec 2011 14:10:11 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id A3E888FC1D for ; Thu, 22 Dec 2011 14:10:11 +0000 (UTC) Received: from freefall.freebsd.org (localhost [127.0.0.1]) by freefall.freebsd.org (8.14.5/8.14.5) with ESMTP id pBMEABqI098184 for ; Thu, 22 Dec 2011 14:10:11 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.5/8.14.5/Submit) id pBMEAB58098183; Thu, 22 Dec 2011 14:10:11 GMT (envelope-from gnats) Resent-Date: Thu, 22 Dec 2011 14:10:11 GMT Resent-Message-Id: <201112221410.pBMEAB58098183@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-ports-bugs@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, Oliver Heesakkers Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 37FBD1065679 for ; Thu, 22 Dec 2011 14:05:15 +0000 (UTC) (envelope-from nobody@FreeBSD.org) Received: from red.freebsd.org (red.freebsd.org [IPv6:2001:4f8:fff6::22]) by mx1.freebsd.org (Postfix) with ESMTP id 26F648FC1B for ; Thu, 22 Dec 2011 14:05:15 +0000 (UTC) Received: from red.freebsd.org (localhost [127.0.0.1]) by red.freebsd.org (8.14.4/8.14.4) with ESMTP id pBME5E2P017555 for ; Thu, 22 Dec 2011 14:05:14 GMT (envelope-from nobody@red.freebsd.org) Received: (from nobody@localhost) by red.freebsd.org (8.14.4/8.14.4/Submit) id pBME5EaB017554; Thu, 22 Dec 2011 14:05:14 GMT (envelope-from nobody) Message-Id: <201112221405.pBME5EaB017554@red.freebsd.org> Date: Thu, 22 Dec 2011 14:05:14 GMT From: Oliver Heesakkers To: freebsd-gnats-submit@FreeBSD.org X-Send-Pr-Version: www-3.1 Cc: Subject: ports/163534: [patch] /audio/clementine-player add option for lastfm (and thus ruby) X-BeenThere: freebsd-ports-bugs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Ports bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 22 Dec 2011 14:10:12 -0000 >Number: 163534 >Category: ports >Synopsis: [patch] /audio/clementine-player add option for lastfm (and thus ruby) >Confidential: no >Severity: non-critical >Priority: low >Responsible: freebsd-ports-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: change-request >Submitter-Id: current-users >Arrival-Date: Thu Dec 22 14:10:11 UTC 2011 >Closed-Date: >Last-Modified: >Originator: Oliver Heesakkers >Release: 9.0-RC3 amd64 >Organization: >Environment: >Description: I'm trying to keep my system(s) free of ruby. The most recent update of clementine-player however pulls in ruby through the Last.fm service. Clementine-player will successfully build when audio/liblastfm is not installed, so simply moving that LIB_DEPEND into an option makes it easily possible to avoid having to build ruby. Since lastfm was heretofore automatic, I defaulted the option to on >How-To-Repeat: Do not have ruby installed. Start the installation of clementine-player and watch it pulling in ruby. >Fix: diff -ruN clementine-player.orig/Makefile clementine-player/Makefile --- clementine-player.orig/Makefile 2011-12-21 05:24:01.000000000 +0100 +++ clementine-player/Makefile 2011-12-22 14:52:04.000000000 +0100 @@ -17,8 +17,7 @@ LICENSE= GPLv3 -LIB_DEPENDS= lastfm.0:${PORTSDIR}/audio/liblastfm \ - tag.1:${PORTSDIR}/audio/taglib \ +LIB_DEPENDS= tag.1:${PORTSDIR}/audio/taglib \ notify.4:${PORTSDIR}/devel/libnotify \ xine.1:${PORTSDIR}/multimedia/libxine \ mtp:${PORTSDIR}/audio/libmtp @@ -37,7 +36,8 @@ USE_GSTREAMER= gio ogg mp3 flac soup vorbis MAKE_JOBS_UNSAFE= yes -OPTIONS= VISUALISATION "Visualisations from projectM" off +OPTIONS= VISUALISATION "Visualisations from projectM" off \ + LASTFM "Support Last.fm service (requires ruby)" on .include @@ -48,4 +48,8 @@ PLIST_SUB+= VSL="@comment " .endif +.if defined(WITH_LASTFM) +LIB_DEPENDS+= lastfm.0:${PORTSDIR}/audio/liblastfm +.endif + .include >Release-Note: >Audit-Trail: >Unformatted: