From owner-cvs-src@FreeBSD.ORG  Thu Apr 10 13:33:12 2003
Return-Path: <owner-cvs-src@FreeBSD.ORG>
Delivered-To: cvs-src@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP
	id 195C037B408; Thu, 10 Apr 2003 13:33:12 -0700 (PDT)
Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115])
	by mx1.FreeBSD.org (Postfix) with ESMTP
	id 7594543FAF; Thu, 10 Apr 2003 13:33:11 -0700 (PDT)
	(envelope-from rwatson@FreeBSD.org)
Received: from repoman.freebsd.org (localhost [127.0.0.1])
	by repoman.freebsd.org (8.12.6/8.12.6) with ESMTP id h3AKXB0U018167;
	Thu, 10 Apr 2003 13:33:11 -0700 (PDT)
	(envelope-from rwatson@repoman.freebsd.org)
Received: (from rwatson@localhost)
	by repoman.freebsd.org (8.12.6/8.12.6/Submit) id h3AKXB0I018166;
	Thu, 10 Apr 2003 13:33:11 -0700 (PDT)
Message-Id: <200304102033.h3AKXB0I018166@repoman.freebsd.org>
From: Robert Watson <rwatson@FreeBSD.org>
Date: Thu, 10 Apr 2003 13:33:11 -0700 (PDT)
To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org,
	cvs-all@FreeBSD.org
X-FreeBSD-CVS-Branch: HEAD
Subject: cvs commit: src/sys/netinet tcp_subr.c
X-BeenThere: cvs-src@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: CVS commit messages for the src tree <cvs-src.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-src>,
	<mailto:cvs-src-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-src>
List-Post: <mailto:cvs-src@freebsd.org>
List-Help: <mailto:cvs-src-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-src>,
	<mailto:cvs-src-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 10 Apr 2003 20:33:12 -0000

rwatson     2003/04/10 13:33:11 PDT

  FreeBSD src repository

  Modified files:
    sys/netinet          tcp_subr.c 
  Log:
  Remove a potential panic condition introduced by reduced TCP wait
  state.  Those changed attempted to work around the changed invariant
  that inp->in_socket was sometimes now NULL, but the logic wasn't
  quite right, meaning that inp->in_socket would be dereferenced by
  cr_canseesocket() if security.bsd.see_other_uids, jail, or MAC
  were in use.  Attempt to clarify and correct the logic.
  
  Note: the work-around originally introduced with the reduced TCP
  wait state handling to use cr_cansee() instead of cr_canseesocket()
  in this case isn't really right, although it "Does the right thing"
  for most of the cases in the base system.  We'll need to address
  this at some point in the future.
  
  Pointed out by: dcs
  Obtained from:  TrustedBSD Project
  Sponsored by:   DARPA, Network Associates Laboratories
  
  Revision  Changes    Path
  1.159     +15 -5     src/sys/netinet/tcp_subr.c