From owner-cvs-all@FreeBSD.ORG Tue May 11 13:26:01 2004 Return-Path: Delivered-To: cvs-all@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 3286B16A4CF for ; Tue, 11 May 2004 13:26:01 -0700 (PDT) Received: from mail4.speakeasy.net (mail4.speakeasy.net [216.254.0.204]) by mx1.FreeBSD.org (Postfix) with ESMTP id 3198043D5C for ; Tue, 11 May 2004 13:26:00 -0700 (PDT) (envelope-from jhb@FreeBSD.org) Received: (qmail 27084 invoked from network); 11 May 2004 20:25:59 -0000 Received: from dsl027-160-063.atl1.dsl.speakeasy.net (HELO server.baldwin.cx) ([216.27.160.63]) (envelope-sender ) encrypted SMTP for ; 11 May 2004 20:25:59 -0000 Received: from 10.50.40.205 (gw1.twc.weather.com [216.133.140.1]) by server.baldwin.cx (8.12.11/8.12.11) with ESMTP id i4BKPuLS006487; Tue, 11 May 2004 16:25:56 -0400 (EDT) (envelope-from jhb@FreeBSD.org) From: John Baldwin To: Nate Lawson Date: Tue, 11 May 2004 16:26:22 -0400 User-Agent: KMail/1.6 References: <20040510115040.0C9B516A53A@hub.freebsd.org> <6.1.0.6.1.20040511194832.03e5e988@popserver.sfu.ca> <20040511122030.I76738@root.org> In-Reply-To: <20040511122030.I76738@root.org> MIME-Version: 1.0 Content-Disposition: inline Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Message-Id: <200405111626.22013.jhb@FreeBSD.org> X-Spam-Checker-Version: SpamAssassin 2.63 (2004-01-11) on server.baldwin.cx cc: cvs-src@FreeBSD.org cc: src-committers@FreeBSD.org cc: cvs-all@FreeBSD.org cc: Colin Percival Subject: Re: cvs commit: src/sys/dev/led led.h X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 11 May 2004 20:26:01 -0000 On Tuesday 11 May 2004 03:23 pm, Nate Lawson wrote: > On Tue, 11 May 2004, Colin Percival wrote: > > At 19:15 11/05/2004, David O'Brien wrote: > > >On Tue, May 11, 2004 at 10:02:59AM -0700, Nate Lawson wrote: > > >> Do we even want __FBSDID in .h files? It doesn't seem to make sense > > >> since it's not a compilation unit (i.e. no linkage). > > > > > >It actually does make sense, as a header's contents does wind up in a .o > > >eventually :-) And header contents can be the cause of problems as much > > >as a .c file. There is no problem having multiple __FBSDID in either > > >a.out or ELF objects. > > > > However, there are problems with having a header file's __FBSDID tags end > > up in a several binaries. Quite apart from the resulting bloat, most > > changes to header files don't actually result in many binaries being > > modified; including compilable $Id$ tags in the headers would result in > > lots of spurious binary changes. This would make me (and anyone who uses > > FreeBSD Update) very unhappy. > > I agree. This creates the same problems as panic() now changing object > files every time a comment is moved or other non-functional change. Seconded on both counts. -- John Baldwin <>< http://www.FreeBSD.org/~jhb/ "Power Users Use the Power to Serve" = http://www.FreeBSD.org