Skip site navigation (1)Skip section navigation (2)
Date:      Tue, 06 Jan 2015 10:35:54 +0100
From:      Hans Petter Selasky <hps@selasky.org>
To:        Craig Rodrigues <rodrigc@FreeBSD.org>, src-committers@freebsd.org,  svn-src-all@freebsd.org, svn-src-head@freebsd.org
Subject:   Re: svn commit: r276747 - head/sys/netpfil/pf
Message-ID:  <54ABAC7A.6080002@selasky.org>
In-Reply-To: <201501060903.t06934qp081875@svn.freebsd.org>
References:  <201501060903.t06934qp081875@svn.freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help
On 01/06/15 09:39, Craig Rodrigues wrote:> Author: rodrigc
 > Date: Tue Jan  6 08:39:06 2015
 > New Revision: 276746
 > URL: https://svnweb.freebsd.org/changeset/base/276746
 >
 > Log:
 >    Merge: r258322 from projects/pf branch
 >
 >        Split functions that initialize various pf parts into their
 >        vimage parts and global parts.
 >        Since global parts appeared to be only mutex initializations, just
 >        abandon them and use MTX_SYSINIT() instead.
 >        Kill my incorrect VNET_FOREACH() iterator and instead use correct
 >        approach with VNET_SYSINIT().
 >
 >    PR:			194515
 >    Differential Revision:	D1309
 >    Submitted by: 		glebius, Nikos Vassiliadis <nvass@gmx.com>
 >    Reviewed by: 		trociny, zec, gnn

This results in the following build failures:

sys/modules/pf/../../netpfil/pf/pf_ioctl.c:3728:3: error: use of 
undeclared identifier 'V_pf_end_threads'
                 V_pf_end_threads = 0;
                 ^
sys/modules/pf/../../netpfil/pf/pf_ioctl.c:3815:6: error: use of 
undeclared identifier 'vnet_pf_init'
             vnet_pf_init, NULL);
             ^
sys/net/vnet.h:414:35: note: expanded from macro 'VNET_SYSINIT'
         SYSINIT(ident, subsystem, order, func, arg)
                                          ^
sys/sys/kernel.h:243:36: note: expanded from macro 'SYSINIT'
         (sysinit_cfunc_t)(sysinit_nfunc_t)func, (void *)(ident))
                                           ^
sys/sys/kernel.h:236:3: note: expanded from macro 'C_SYSINIT'
                 func

--HPS



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?54ABAC7A.6080002>