Date: Mon, 05 Feb 2007 19:20:02 +0000 From: Florent Thoumie <flz@FreeBSD.org> To: Norikatsu Shigemura <nork@FreeBSD.org> Cc: freebsd-bugs@FreeBSD.org, FreeBSD-gnats-submit@FreeBSD.org, freebsd-rc@FreeBSD.org Subject: Re: conf/104884: Add support EtherChannel configuration to rc.conf Message-ID: <45C78362.4030003@FreeBSD.org> In-Reply-To: <20070129000459.b2dba4e0.nork@FreeBSD.org> References: <20061029010934.5afef73e.nork@FreeBSD.org> <200610281610.k9SGAIVb051055@freefall.freebsd.org> <20070129000459.b2dba4e0.nork@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enig10F7C438CF396E3BC8035EEA Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Norikatsu Shigemura wrote: > On Sat, 28 Oct 2006 16:10:18 GMT > FreeBSD-gnats-submit@FreeBSD.org wrote: >> Thank you very much for your problem report. >> It has the internal identification `conf/104884'. >> The individual assigned to look at your >> report is: freebsd-bugs.=20 >> You can access the state of your problem report at any time >> via this link: >> http://www.freebsd.org/cgi/query-pr.cgi?pr=3D104884 >>> Category: conf >>> Responsible: freebsd-bugs >>> Synopsis: Add support EtherChannel configuration to rc.conf >>> Arrival-Date: Sat Oct 28 16:10:18 GMT 2006 >=20 > I chased HEAD. Please see following patch. > Anyone, please handle this PR? > And I'll make a patch for 6-stable. I just noticed two other things. > +# fec_up ifn ^^^ fec_up uses fec_interfaces, not $1, so this is wrong. > +# Configure Fast EtherChannel for interface $ifn. Returns 0 if FEC > +# arguments were found and configured; returns 1 otherwise. fec_up is never called with an argument anyway at the moment. It wouldn't be hard to do: work on $1 or $fec_interfaces if $1 is empty. I guess we could use both 'fec_up $ifn' and 'gif_up $ifn' in rc.d/netif. The newly introduced variables also need to be documented in rc.conf.5. Could you please provide a patch for this? I also noticed we don't have gif_down (hence no fec_down). --=20 Florent Thoumie flz@FreeBSD.org FreeBSD Committer --------------enig10F7C438CF396E3BC8035EEA Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.5 (FreeBSD) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org iD8DBQFFx4NqMxEkbVFH3PQRCpa7AJ92OTvKEnTFuvgd8dxE9qMOeslJAgCfS8nk NzppeTdeSYYb8h+DjhsHluc= =GH+e -----END PGP SIGNATURE----- --------------enig10F7C438CF396E3BC8035EEA--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?45C78362.4030003>