Skip site navigation (1)Skip section navigation (2)
Date:      Thu, 11 Feb 2010 16:23:10 -0800
From:      Doug Barton <dougb@FreeBSD.org>
To:        Dmitry Marakasov <amdmi3@amdmi3.ru>
Cc:        cvs-ports@FreeBSD.org, Alexey Dokuchaev <danfe@FreeBSD.org>, cvs-all@FreeBSD.org, ports-committers@FreeBSD.org
Subject:   Re: cvs commit: ports/audio Makefile ports/audio/deadbeef Makefile distinfo pkg-descr pkg-plist ports/audio/deadbeef/files patch-Makefile.am patch-Makefile.in patch-configure patch-configure.ac
Message-ID:  <4B749F6E.5020806@FreeBSD.org>
In-Reply-To: <20100210125022.GD1538@hades.panopticon>
References:  <201002092323.o19NNRvB090976@repoman.freebsd.org> <20100210092407.GA30717@FreeBSD.org> <20100210125022.GD1538@hades.panopticon>

next in thread | previous in thread | raw e-mail | index | archive | help
On 02/10/10 04:50, Dmitry Marakasov wrote:
>>>    1.1       +13 -0     ports/audio/deadbeef/files/patch-Makefile.am (new)
>>>    1.1       +21 -0     ports/audio/deadbeef/files/patch-Makefile.in (new)
>>
>> Weird.  Can you explain why both of these patches are required, since .in
>> is normally generated from .am (that is, patching .in is enough unless
>> the port needs more of autotools magic than simple "./configure")?
>
> Configure tends to rerun autotools when available sometimes, thus files
> gets regenerated, so to be on a safe side, sources are patched as well.
> Anyway, these patches will go away with the next update.

Yes, TMK it has always been common practice to patch both files "just in 
case." One never knows what may happen with future versions of auto*, 
for example.


Doug

-- 

	... and that's just a little bit of history repeating.
			-- Propellerheads

	Improve the effectiveness of your Internet presence with
	a domain name makeover!    http://SupersetSolutions.com/




Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?4B749F6E.5020806>