Date: Tue, 25 Apr 2017 11:30:17 -0700 (PDT) From: "Rodney W. Grimes" <freebsd@pdx.rh.CN85.dnsmgr.net> To: Gleb Smirnoff <glebius@freebsd.org> Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r317409 - head/contrib/tcpdump Message-ID: <201704251830.v3PIUHdb062645@pdx.rh.CN85.dnsmgr.net> In-Reply-To: <201704251556.v3PFuk5U053547@repo.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
[ Charset UTF-8 unsupported, converting... ] > Author: glebius > Date: Tue Apr 25 15:56:46 2017 > New Revision: 317409 > URL: https://svnweb.freebsd.org/changeset/base/317409 > > Log: > Cherry-pick 5d3c5151c2b885aab36627bafb8539238da27b2d, it fixes use after free Lets not use git hashes as references in commit messages, it has very little value for someone reading a log of changes looking for something. There is no promise that it can be found later (github can go Poof). > if tcpdump(1) is run on non-existent interface. > > Suggested by: zeising > > Modified: > head/contrib/tcpdump/tcpdump.c > > Modified: head/contrib/tcpdump/tcpdump.c > ============================================================================== > --- head/contrib/tcpdump/tcpdump.c Tue Apr 25 13:17:34 2017 (r317408) > +++ head/contrib/tcpdump/tcpdump.c Tue Apr 25 15:56:46 2017 (r317409) > @@ -1085,9 +1085,9 @@ open_interface(const char *device, netdi > /* > * Return an error for our caller to handle. > */ > - pcap_close(pc); > snprintf(ebuf, PCAP_ERRBUF_SIZE, "%s: %s\n(%s)", > device, pcap_statustostr(status), cp); > + pcap_close(pc); > return (NULL); > } else if (status == PCAP_ERROR_PERM_DENIED && *cp != '\0') > error("%s: %s\n(%s)", device, > > -- Rod Grimes rgrimes@freebsd.org
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201704251830.v3PIUHdb062645>