Date: Fri, 1 Oct 2010 14:03:36 +0000 From: mdf@FreeBSD.org To: Andriy Gapon <avg@freebsd.org> Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r213322 - head/sys/kern Message-ID: <AANLkTi=KaKVDx9bTXZwAXWpAeQ6vNpTYFiXn8Xht2Fd-@mail.gmail.com> In-Reply-To: <201010010934.o919YfCB097349@svn.freebsd.org> References: <201010010934.o919YfCB097349@svn.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Fri, Oct 1, 2010 at 9:34 AM, Andriy Gapon <avg@freebsd.org> wrote: > Author: avg > Date: Fri Oct =A01 09:34:41 2010 > New Revision: 213322 > URL: http://svn.freebsd.org/changeset/base/213322 > > Log: > =A0sysctls in kern_shutdown: add twin tunables > > =A0also make couple of sysctl-controlled variables static > > =A0Reviewed by: =A0rwatson > =A0MFC after: =A0 =A01 week > > Modified: > =A0head/sys/kern/kern_shutdown.c > > Modified: head/sys/kern/kern_shutdown.c > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D > --- head/sys/kern/kern_shutdown.c =A0 =A0 =A0 Fri Oct =A01 09:18:30 2010 = =A0 =A0 =A0 =A0(r213321) > +++ head/sys/kern/kern_shutdown.c =A0 =A0 =A0 Fri Oct =A01 09:34:41 2010 = =A0 =A0 =A0 =A0(r213322) > @@ -98,21 +98,24 @@ int debugger_on_panic =3D 0; > =A0#else > =A0int debugger_on_panic =3D 1; > =A0#endif > -SYSCTL_INT(_debug, OID_AUTO, debugger_on_panic, CTLFLAG_RW, > +SYSCTL_INT(_debug, OID_AUTO, debugger_on_panic, CTLFLAG_RW | CTLFLAG_TUN= , > =A0 =A0 =A0 =A0&debugger_on_panic, 0, "Run debugger on kernel panic"); I thought CTLFLAG_TUN was only used to provide a more useful error message when writing to a read-only sysctl? I think the CTLFLAG_TUN should not be here for a RW sysctl. Thanks, matthew > +TUNABLE_INT("debug.debugger_on_panic", &debugger_on_panic); > > =A0#ifdef KDB_TRACE > -int trace_on_panic =3D 1; > +static int trace_on_panic =3D 1; > =A0#else > -int trace_on_panic =3D 0; > +static int trace_on_panic =3D 0; > =A0#endif > -SYSCTL_INT(_debug, OID_AUTO, trace_on_panic, CTLFLAG_RW, > +SYSCTL_INT(_debug, OID_AUTO, trace_on_panic, CTLFLAG_RW | CTLFLAG_TUN, > =A0 =A0 =A0 =A0&trace_on_panic, 0, "Print stack trace on kernel panic"); > +TUNABLE_INT("debug.trace_on_panic", &trace_on_panic); > =A0#endif /* KDB */ > > -int sync_on_panic =3D 0; > -SYSCTL_INT(_kern, OID_AUTO, sync_on_panic, CTLFLAG_RW, > +static int sync_on_panic =3D 0; > +SYSCTL_INT(_kern, OID_AUTO, sync_on_panic, CTLFLAG_RW | CTLFLAG_TUN, > =A0 =A0 =A0 =A0&sync_on_panic, 0, "Do a sync before rebooting from a pani= c"); > +TUNABLE_INT("kern.sync_on_panic", &sync_on_panic); > > =A0SYSCTL_NODE(_kern, OID_AUTO, shutdown, CTLFLAG_RW, 0, "Shutdown enviro= nment"); > >
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?AANLkTi=KaKVDx9bTXZwAXWpAeQ6vNpTYFiXn8Xht2Fd->