From owner-freebsd-doc@FreeBSD.ORG Fri Jan 7 12:25:01 2011 Return-Path: Delivered-To: freebsd-doc@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 47FA5106566B; Fri, 7 Jan 2011 12:25:01 +0000 (UTC) (envelope-from joris.dedieu@gmail.com) Received: from mail-fx0-f54.google.com (mail-fx0-f54.google.com [209.85.161.54]) by mx1.freebsd.org (Postfix) with ESMTP id 852808FC12; Fri, 7 Jan 2011 12:25:00 +0000 (UTC) Received: by fxm16 with SMTP id 16so16830174fxm.13 for ; Fri, 07 Jan 2011 04:24:59 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:received:received:in-reply-to :references:date:message-id:subject:from:to:cc:content-type :content-transfer-encoding; bh=RJ/NpOvuFPzAQxuXm9vkjCqA8lTGghnUYjeVCrTtw6A=; b=C+a4txAGTE0fG5r6L0Xgcps+79nVM2X9D0rusLxskUBK4L6EuBuO+bWe+b3KWm5p6N LiRjpZTENlSdiXwp1cnmj+ldoTRygkOeyvv4l1Y3VBOkjT1vFjmYChfadjTms4rIR3Pa sgRC8Z151KnZR4hM3QQ5jvx96Ug3dxk8sNOFg= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type:content-transfer-encoding; b=eLUIS6lc/w1ZB4ORutPovjJJodL0nzSLSxMmjLjqQPmC94Vw8cP812RF4NtCAxosB9 /VAoFMJSJSEKR2FSf/gAXEJnCg1JkSJHFqaruBP73sDp7Z/u3W1iUBi8UNazZ8jy1td6 1K/tVsgFSRoHuH7Si4Kqe97e0nkRzB5a6gZX8= MIME-Version: 1.0 Received: by 10.223.95.199 with SMTP id e7mr1411864fan.39.1294401501741; Fri, 07 Jan 2011 03:58:21 -0800 (PST) Received: by 10.223.86.207 with HTTP; Fri, 7 Jan 2011 03:58:21 -0800 (PST) In-Reply-To: <201101031406.18219.jhb@freebsd.org> References: <201101031758.p03Hwr7k054742@red.freebsd.org> <201101031406.18219.jhb@freebsd.org> Date: Fri, 7 Jan 2011 12:58:21 +0100 Message-ID: From: joris dedieu To: John Baldwin Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Cc: freebsd-doc@freebsd.org, freebsd-gnats-submit@freebsd.org Subject: Re: docs/153654: [patch] incorrect include in sysctl.9 X-BeenThere: freebsd-doc@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Documentation project List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 07 Jan 2011 12:25:01 -0000 2011/1/3 John Baldwin : > On Monday, January 03, 2011 12:58:53 pm Joris Dedieu wrote: >> >> >Number: =A0 =A0 =A0 =A0 153654 >> >Category: =A0 =A0 =A0 docs >> >Synopsis: =A0 =A0 =A0 [patch] incorrect include in sysctl.9 >> >Confidential: =A0 no >> >Severity: =A0 =A0 =A0 non-critical >> >Priority: =A0 =A0 =A0 low >> >Responsible: =A0 =A0freebsd-doc >> >State: =A0 =A0 =A0 =A0 =A0open >> >Quarter: >> >Keywords: >> >Date-Required: >> >Class: =A0 =A0 =A0 =A0 =A0doc-bug >> >Submitter-Id: =A0 current-users >> >Arrival-Date: =A0 Mon Jan 03 18:00:24 UTC 2011 >> >Closed-Date: >> >Last-Modified: >> >Originator: =A0 =A0 Joris Dedieu >> >Release: =A0 =A0 =A0 =A08.1-RELEASE-p2 >> >Organization: >> >Environment: >> FreeBSD ladybug2.rmdir.fr 8.1-RELEASE-p2 FreeBSD 8.1-RELEASE-p2 #0: Mon = Dec 27 15:39:23 CET 2010 > joris@ladybug2.rmdir.fr:/usr/obj/usr/src/sys/GENERIC =A0amd64 >> >> >Description: >> Has DATA_SET is defined in sys/kernel.h most SYSTL_* macros don't work i= f you don't include it. >> >How-To-Repeat: >> >> >Fix: >> --- share/man/man9/sysctl.9.orig =A0 =A0 =A0 =A02011-01-03 18:43:53.0000= 00000 +0100 >> +++ share/man/man9/sysctl.9 =A0 =A0 2011-01-03 18:44:17.000000000 +0100 >> @@ -44,7 +44,7 @@ >> =A0.Nm SYSCTL_QUAD >> =A0.Nd Static sysctl declaration functions >> =A0.Sh SYNOPSIS >> -.In sys/types.h >> +.In sys/kernel.h >> =A0.In sys/sysctl.h >> =A0.Fn SYSCTL_DECL name >> =A0.Fn SYSCTL_INT parent nbr name access ptr val descr > > does not include . =A0Plus, all of > is not needed. =A0 is what defines DATA_SET(). =A0This = is > probably the "right" set of includes: > > #include > #include > #include > > OTOH, should perhaps have a nested include of > in the #ifdef _KERNEL case in which case the manpage would not need chang= ing. You are right. My patch is wrong and your solution sounds better. Should I submit an other pr ? Joris > > -- > John Baldwin >