From owner-cvs-all@FreeBSD.ORG  Fri Feb 12 00:25:33 2010
Return-Path: <owner-cvs-all@FreeBSD.ORG>
Delivered-To: cvs-all@FreeBSD.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id E5A3C106566C;
	Fri, 12 Feb 2010 00:25:33 +0000 (UTC)
	(envelope-from pgollucci@p6m7g8.com)
Received: from EXHUB015-4.exch015.msoutlookonline.net
	(exhub015-4.exch015.msoutlookonline.net [207.5.72.96])
	by mx1.freebsd.org (Postfix) with ESMTP id C59558FC17;
	Fri, 12 Feb 2010 00:25:33 +0000 (UTC)
Received: from [172.28.1.196] (174.79.184.239) by smtpx15.msoutlookonline.net
	(207.5.72.103) with Microsoft SMTP Server (TLS) id 8.2.176.0;
	Thu, 11 Feb 2010 16:25:32 -0800
Message-ID: <4B749FFB.80506@p6m7g8.com>
Date: Thu, 11 Feb 2010 19:25:31 -0500
From: "Philip M. Gollucci" <pgollucci@p6m7g8.com>
Organization: P6 Web Applications
User-Agent: Mozilla/5.0 (Windows; U; Windows NT 6.0; en-US;
	rv:1.9.1.7) Gecko/20100111 Lightning/1.0b1 Thunderbird/3.0.1
MIME-Version: 1.0
To: Doug Barton <dougb@FreeBSD.org>
References: <201002092323.o19NNRvB090976@repoman.freebsd.org>
	<20100210092407.GA30717@FreeBSD.org>
	<20100210125022.GD1538@hades.panopticon>
	<4B749F6E.5020806@FreeBSD.org>
In-Reply-To: <4B749F6E.5020806@FreeBSD.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Cc: cvs-ports@FreeBSD.org, Alexey Dokuchaev <danfe@FreeBSD.org>,
	Dmitry Marakasov <amdmi3@amdmi3.ru>, cvs-all@FreeBSD.org,
	ports-committers@FreeBSD.org
Subject: Re: cvs commit: ports/audio Makefile ports/audio/deadbeef Makefile
 distinfo pkg-descr pkg-plist ports/audio/deadbeef/files
 patch-Makefile.am
 patch-Makefile.in patch-configure patch-configure.ac
X-BeenThere: cvs-all@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: **OBSOLETE** CVS commit messages for the entire tree
	<cvs-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-all>
List-Post: <mailto:cvs-all@freebsd.org>
List-Help: <mailto:cvs-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 12 Feb 2010 00:25:34 -0000

On 2/11/2010 7:23 PM, Doug Barton wrote:
> On 02/10/10 04:50, Dmitry Marakasov wrote:
>>>>    1.1       +13 -0     ports/audio/deadbeef/files/patch-Makefile.am
>>>> (new)
>>>>    1.1       +21 -0     ports/audio/deadbeef/files/patch-Makefile.in
>>>> (new)
> Doug

Since when?  I've not once in 2 yrs seen someone patch both.  What I do
know is that we *try* to always patch the .am/.ac files and use
USE_AUTOTOOLS to re-generate the .in files.

AFAIK, this is to keep the diffs *actually* reviewable.

Can you point to another port that patches both?  If so, I'll update my
work flow to do it too.




-- 
------------------------------------------------------------------------
1024D/DB9B8C1C B90B FBC3 A3A1 C71A 8E70  3F8C 75B8 8FFB DB9B 8C1C
Philip M. Gollucci (pgollucci@p6m7g8.com) c: 703.336.9354
VP Apache Infrastructure; Member, Apache Software Foundation
Committer,                        FreeBSD Foundation
Sr. System Admin,                 Ridecharge Inc.
Consultant,                       P6M7G8 Inc.

Work like you don't need the money,
love like you'll never get hurt,
and dance like nobody's watching.