From owner-p4-projects@FreeBSD.ORG Sat Jun 5 21:55:24 2010 Return-Path: Delivered-To: p4-projects@freebsd.org Received: by hub.freebsd.org (Postfix, from userid 32767) id DB3CC106567A; Sat, 5 Jun 2010 21:55:23 +0000 (UTC) Delivered-To: perforce@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 9EE1A1065677; Sat, 5 Jun 2010 21:55:23 +0000 (UTC) (envelope-from yanegomi@gmail.com) Received: from mail-iw0-f182.google.com (mail-iw0-f182.google.com [209.85.214.182]) by mx1.freebsd.org (Postfix) with ESMTP id 4FD948FC17; Sat, 5 Jun 2010 21:55:23 +0000 (UTC) Received: by iwn5 with SMTP id 5so2751365iwn.13 for ; Sat, 05 Jun 2010 14:55:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:received:sender:received :in-reply-to:references:date:x-google-sender-auth:message-id:subject :from:to:cc:content-type:content-transfer-encoding; bh=ilPfludQuV41Ol9U89joLlqgRNYgg9cVS00gRLlB02c=; b=Y/prZhJXwcnWHxK75M4dEiIoFodv8rM7wxzZ0/sBhhvlr21ssDiR18fYCX82p/V30T C281s4mKQlCn5a72s6t/D7Me1zhevM3ZhOoDuEj7pMqbiaRGe6gm3VkZmZsqQ3Ijz/JI 4Iz7qvKfYZDtqmr7Hh/chYa+IsSfcSD2X3prA= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:sender:in-reply-to:references:date :x-google-sender-auth:message-id:subject:from:to:cc:content-type :content-transfer-encoding; b=lPCbQ/sk8YJC0FUqOyfUM6b7hCmUaacXZEmeLzvmkSMrVQr1f8OT4onw3ceg10xNY5 yvQ3uk7UDI+4ScXW+IGMGoLY2JpjEDi7mPblPWAqEffRNFw/bEvSTDD+DqF5CMEyTjI3 bQfCREdNTn8zu7piYOviPoKFWah3xpZrKMD0M= MIME-Version: 1.0 Received: by 10.231.119.71 with SMTP id y7mr2591578ibq.158.1275774922262; Sat, 05 Jun 2010 14:55:22 -0700 (PDT) Sender: yanegomi@gmail.com Received: by 10.231.69.19 with HTTP; Sat, 5 Jun 2010 14:55:22 -0700 (PDT) In-Reply-To: <201006050617.o556HA8L019323@repoman.freebsd.org> References: <201006050617.o556HA8L019323@repoman.freebsd.org> Date: Sat, 5 Jun 2010 14:55:22 -0700 X-Google-Sender-Auth: HL0IY-Crc8SHUn1VSQm_0ekBzm8 Message-ID: From: Garrett Cooper To: Julien Laffaye Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Cc: Perforce Change Reviews Subject: Re: PERFORCE change 179200 for review X-BeenThere: p4-projects@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: p4 projects tree changes List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 05 Jun 2010 21:55:24 -0000 On Fri, Jun 4, 2010 at 11:17 PM, Julien Laffaye wrot= e: > http://p4web.freebsd.org/@@179200?ac=3D10 > > Change 179200 by jlaffaye@jlaffaye-chulak on 2010/06/05 06:16:29 > > =A0 =A0 =A0 =A0Changed the prototype of unpack_to_buffer() > =A0 =A0 =A0 =A0It is more useful now as we know the size of the buffer. > > Affected files ... > > .. //depot/projects/soc2010/pkg_complete/lib/libpkg/file.c#4 edit > .. //depot/projects/soc2010/pkg_complete/lib/libpkg/pkg.h#5 edit > > Differences ... > > =3D=3D=3D=3D //depot/projects/soc2010/pkg_complete/lib/libpkg/file.c#4 (t= ext+ko) =3D=3D=3D=3D > > @@ -335,20 +335,18 @@ > =A0* Unpack a single file, denoted by file, to a buffer. It proceeds to r= ead it > =A0* into the buffer which will need to be freed by the user at a later d= ate. > =A0* > - * Returns an address to a buffer with the contents of *file if successf= ul, or > - * returns NULL on failure. > + * Returns the size of the buffer if successful, or returns 0 on failure=