Skip site navigation (1)Skip section navigation (2)
Date:      Wed, 30 Jun 2004 09:14:05 +0200
From:      Matthias Andree <matthias.andree@gmx.de>
To:        Mark Linimon <linimon@FreeBSD.org>
Cc:        fox@vader.aacc.cc.md.us
Subject:   Re: ports/68450: [patch] ports/database/db[234]/pkg-descr spelling and grammar nits
Message-ID:  <20040630071405.GC8257@merlin.emma.line.org>
In-Reply-To: <200406300600.i5U6002X091770@freefall.freebsd.org>
References:  <200406300600.i5U6002X091770@freefall.freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help
I'm sanctioning the changes as such
but not the way they have taken into the CVS.

1. to the submitter, fox@:
   PRs should be Cc:d to the port maintainer

2. to the committer, Mark:
   The changes were neither important nor urgent, so there was no reason
   for the committer to go ahead and commit without asking feedback first.

Please let's stick to the regular "maintainer gives his OK, committer
reviews and only then commits" principle that is one of the building
blocks of the quality of the build system.

I'll agree to commits and possibly fix them up later when they address
an issue that is both urgent and important. This certainly wasn't.

-- 
Matthias Andree

Encrypted mail welcome: my GnuPG key ID is 0x052E7D95 (PGP/MIME preferred)



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20040630071405.GC8257>