From owner-svn-src-projects@FreeBSD.ORG Sat Mar 17 16:10:57 2012 Return-Path: Delivered-To: svn-src-projects@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 6EFED10656D9; Sat, 17 Mar 2012 16:10:57 +0000 (UTC) (envelope-from kostikbel@gmail.com) Received: from mail.zoral.com.ua (mx0.zoral.com.ua [91.193.166.200]) by mx1.freebsd.org (Postfix) with ESMTP id B65DE8FC0C; Sat, 17 Mar 2012 16:10:56 +0000 (UTC) Received: from skuns.kiev.zoral.com.ua (localhost [127.0.0.1]) by mail.zoral.com.ua (8.14.2/8.14.2) with ESMTP id q2HGApS5068796; Sat, 17 Mar 2012 18:10:51 +0200 (EET) (envelope-from kostikbel@gmail.com) Received: from deviant.kiev.zoral.com.ua (kostik@localhost [127.0.0.1]) by deviant.kiev.zoral.com.ua (8.14.5/8.14.5) with ESMTP id q2HGApOY002451; Sat, 17 Mar 2012 18:10:51 +0200 (EET) (envelope-from kostikbel@gmail.com) Received: (from kostik@localhost) by deviant.kiev.zoral.com.ua (8.14.5/8.14.5/Submit) id q2HGAphX002450; Sat, 17 Mar 2012 18:10:51 +0200 (EET) (envelope-from kostikbel@gmail.com) X-Authentication-Warning: deviant.kiev.zoral.com.ua: kostik set sender to kostikbel@gmail.com using -f Date: Sat, 17 Mar 2012 18:10:50 +0200 From: Konstantin Belousov To: Pawel Jakub Dawidek Message-ID: <20120317161050.GI75778@deviant.kiev.zoral.com.ua> References: <201203170318.q2H3ITdI047893@svn.freebsd.org> <20120317085116.GC1340@garage.freebsd.pl> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="Rrd1FBYt5NX8iyQT" Content-Disposition: inline In-Reply-To: <20120317085116.GC1340@garage.freebsd.pl> User-Agent: Mutt/1.4.2.3i X-Virus-Scanned: clamav-milter 0.95.2 at skuns.kiev.zoral.com.ua X-Virus-Status: Clean X-Spam-Status: No, score=-4.0 required=5.0 tests=ALL_TRUSTED,AWL,BAYES_00 autolearn=ham version=3.2.5 X-Spam-Checker-Version: SpamAssassin 3.2.5 (2008-06-10) on skuns.kiev.zoral.com.ua Cc: svn-src-projects@FreeBSD.org, Grzegorz Bernacki , src-committers@FreeBSD.org Subject: Re: svn commit: r233072 - projects/nand/sys/kern X-BeenThere: svn-src-projects@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "SVN commit messages for the src " projects" tree" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 17 Mar 2012 16:10:57 -0000 --Rrd1FBYt5NX8iyQT Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sat, Mar 17, 2012 at 09:51:16AM +0100, Pawel Jakub Dawidek wrote: > On Sat, Mar 17, 2012 at 03:18:29AM +0000, Grzegorz Bernacki wrote: > > Author: gber > > Date: Sat Mar 17 03:18:28 2012 > > New Revision: 233072 > > URL: http://svn.freebsd.org/changeset/base/233072 > >=20 > > Log: > > Add VFS changes necessary for NANDFS to work. > > =20 > > Ignore B_MANAGED buffer by syncer and ignore signal when msleep as it > > can cause file system inconsistency. >=20 > I'd suggest running these changes through kib@. Especially vn_start_write= () > change below looks ugly, but maybe it is only temporary? It is not only ugly (and object against it). If the change makes any difference for the filesystem, then I just argue that the filesystem is broken. The vn_start_write() is done on the VFS entry peripheral, long before filesystem code is hit. I did not looked at the managed changes, you would need to describe=20 what is wrong with current code and what is the purpose of the changes. B_MANAGED came from xfs, it seems, or at least xfs is the only current consumer of B_MANAGED buffers. --Rrd1FBYt5NX8iyQT Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.12 (FreeBSD) iEYEARECAAYFAk9kt4oACgkQC3+MBN1Mb4imjwCbBfhIB+x7m08MpjbfoQTxO3vB GlIAniz96PXFYEynZ2RDiIkxJaJKvzXO =karN -----END PGP SIGNATURE----- --Rrd1FBYt5NX8iyQT--