From owner-svn-src-all@FreeBSD.ORG Wed Nov 25 16:28:10 2009 Return-Path: Delivered-To: svn-src-all@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 62B5F106566C; Wed, 25 Nov 2009 16:28:10 +0000 (UTC) (envelope-from ume@mahoroba.org) Received: from asuka.mahoroba.org (ent.mahoroba.org [IPv6:2001:2f0:104:8010::1]) by mx1.freebsd.org (Postfix) with ESMTP id E39808FC12; Wed, 25 Nov 2009 16:28:09 +0000 (UTC) Received: from yuga.mahoroba.org (ume@yuga.mahoroba.org [IPv6:2001:2f0:104:8010:21b:d3ff:fe38:5381]) (user=ume mech=CRAM-MD5 bits=0) by asuka.mahoroba.org (8.14.3/8.14.3) with ESMTP/inet6 id nAPGS2AA008626 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Thu, 26 Nov 2009 01:28:02 +0900 (JST) (envelope-from ume@mahoroba.org) Date: Thu, 26 Nov 2009 01:28:02 +0900 Message-ID: From: Hajimu UMEMOTO To: Juli Mallett In-Reply-To: References: <200911221651.nAMGpiIO023873@svn.freebsd.org> User-Agent: xcite1.58> Wanderlust/2.15.7 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?ISO-2022-JP-2?B?R29qGyQoRCtXGyhC?=) APEL/10.7 Emacs/23.1 (i386-portbld-freebsd8.0) MULE/6.0 (HANACHIRUSATO) X-Operating-System: FreeBSD 8.0-RELEASE X-PGP-Key: http://www.imasy.or.jp/~ume/publickey.asc X-PGP-Fingerprint: 1F00 0B9E 2164 70FC 6DC5 BF5F 04E9 F086 BF90 71FE Organization: Internet Mutual Aid Society, YOKOHAMA MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.2.3 (asuka.mahoroba.org [IPv6:2001:2f0:104:8010::1]); Thu, 26 Nov 2009 01:28:02 +0900 (JST) X-Virus-Scanned: clamav-milter 0.95.3 at asuka.mahoroba.org X-Virus-Status: Clean X-Spam-Status: No, score=-2.6 required=5.0 tests=AWL,BAYES_00 autolearn=ham version=3.2.5 X-Spam-Checker-Version: SpamAssassin 3.2.5 (2008-06-10) on asuka.mahoroba.org Cc: svn-src-head@FreeBSD.org, svn-src-all@FreeBSD.org, src-committers@FreeBSD.org Subject: Re: svn commit: r199655 - head/usr.bin/w X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 25 Nov 2009 16:28:10 -0000 Hi, >>>>> On Tue, 24 Nov 2009 17:18:49 -0800 >>>>> Juli Mallett said: jmallett> I'm not sure this is right. While the manpage implies that doing no jmallett> resolution means that it will show numeric addresses, since that is jmallett> not correct, there are two ways to go. As you have done, you can jmallett> choose to try to resolve hostnames to IP addresses. You could also do jmallett> as the code before did and do no resolution. I frequently use 'w -n' jmallett> on systems with slow nameservers to see who is logged in without jmallett> triggering a bunch of DNS traffic that I then have to wait for. jmallett> Trying to resolve the name to a numeric address presents that problem. jmallett> Since it is not possible to always show a numeric address (if, for jmallett> example, the hostname is no longer valid) I'm not sure that this is jmallett> the right direction to try to go with 'w -n'. The feature was present in the past, and was dropped by 1.48. The reason is that we have no idea what address family they belong to. So, I reintroduce it for just one A/AAAA RR case. http://www.freebsd.org/cgi/cvsweb.cgi/src/usr.bin/w/w.c#rev1.48 However, a hostname in utmp is truncated in many cases. It is useless to query for a truncated hostname. How about this patch? Index: usr.bin/w/w.c diff -u -p usr.bin/w/w.c.orig usr.bin/w/w.c --- usr.bin/w/w.c.orig 2009-11-21 20:27:35.000000000 +0900 +++ usr.bin/w/w.c 2009-11-25 12:40:19.142972545 +0900 @@ -383,7 +383,7 @@ main(int argc, char *argv[]) if (isaddr && realhostname_sa(fn, sizeof(fn), sa, sa->sa_len) == HOSTNAME_FOUND) p = fn; - } else if (!isaddr) { + } else if (!isaddr && strlen(p) < UT_HOSTSIZE) { /* * If a host has only one A/AAAA RR, change a * name into an IP address Sincerely, -- Hajimu UMEMOTO @ Internet Mutual Aid Society Yokohama, Japan ume@mahoroba.org ume@{,jp.}FreeBSD.org http://www.imasy.org/~ume/