From owner-freebsd-bugs Sat Nov 23 16: 5:39 2002 Delivered-To: freebsd-bugs@hub.freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 6434337B401; Sat, 23 Nov 2002 16:05:38 -0800 (PST) Received: from freefall.freebsd.org (freefall.freebsd.org [216.136.204.21]) by mx1.FreeBSD.org (Postfix) with ESMTP id 11D6243E9C; Sat, 23 Nov 2002 16:05:38 -0800 (PST) (envelope-from njl@FreeBSD.org) Received: from freefall.freebsd.org (njl@localhost [127.0.0.1]) by freefall.freebsd.org (8.12.6/8.12.6) with ESMTP id gAO05bx3013272; Sat, 23 Nov 2002 16:05:37 -0800 (PST) (envelope-from njl@freefall.freebsd.org) Received: (from njl@localhost) by freefall.freebsd.org (8.12.6/8.12.6/Submit) id gAO05bqs013268; Sat, 23 Nov 2002 16:05:37 -0800 (PST) Date: Sat, 23 Nov 2002 16:05:37 -0800 (PST) From: Nate Lawson Message-Id: <200211240005.gAO05bqs013268@freefall.freebsd.org> To: njl@FreeBSD.org, freebsd-bugs@FreeBSD.org, sos@FreeBSD.org Subject: Re: bin/45547: a patch to make burncd handle .wav files. Sender: owner-freebsd-bugs@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.org Synopsis: a patch to make burncd handle .wav files. Responsible-Changed-From-To: freebsd-bugs->sos Responsible-Changed-By: njl Responsible-Changed-When: Sat Nov 23 15:57:23 PST 2002 Responsible-Changed-Why: Over to burncd(8) maintainer. Patch looks like it could need some cleaning up (i.e. unnecessary one-use macros, definition of a struct for a single use). Try to minimize your diff size by doing things like reading 8 bytes and comparing to "RIFFWAVE" instead of doing it separately. Also you need a little endian conversion for the length field. http://www.freebsd.org/cgi/query-pr.cgi?pr=45547 To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-bugs" in the body of the message