Date: Fri, 15 Nov 2002 21:30:44 +1100 (EST) From: Bruce Evans <bde@zeta.org.au> To: Soeren Schmidt <sos@spider.deepcore.dk> Cc: Conrad Sabatier <conrads@cox.net>, <freebsd-current@FreeBSD.ORG>, <freebsd-multimedia@FreeBSD.ORG> Subject: Re: /dev/acd*t* no longer available in -current? Message-ID: <20021115211212.X13725-100000@gamplex.bde.org> In-Reply-To: <200211141827.gAEIRRQG026591@spider.deepcore.dk>
next in thread | previous in thread | raw e-mail | index | archive | help
On Thu, 14 Nov 2002, Soeren Schmidt wrote: > It seems Bruce Evans wrote: > > Single-digit track numbers are correct and are still generated by MAKEDEV. > > Single digit track numbers are wrong and should be fixed in MAKEDEV. I disagree. > > Contrary to the log message, %02d is harder for scripts. It gives many > > more cases to handle: > > - %d format under RELENG_4 > > Should be fixed. Apart from being wrong, this would break compatibility with released versions of RELENG_4 (except 4.0-4.2 since they didn't support tracks on acd). > > - %d format under -current in the non-devfs case > > DEVFS should be considered mandatory for the track devices on current. No thanks. I only use devfs to debug it. > > - %d format under -current even in the devfs case for track numbers >= 100 > > BZZT!! there can be a max of 99 tracks on a CD. Thnaks for your polite correction. I was misled by MAKEDEV supporting track numbers up to 169. Google agrees that the maximum is 99, but cd drivers in linux-2.4.1 have an interesting number of different definitions of the maximum: aztcd.h:#define MAX_TRACKS 104 cdu31a.h:#define MAX_TRACKS 100 /* The maximum tracks a disk may have. */ gscd.h:#define MAX_TRACKS 104 mcd.h:#define MAX_TRACKS 104 optcd.c:#define MAX_TRACKS 111 sbpcd.h:#define MAX_TRACKS 99 sjcd.h:#define SJCD_MAX_TRACKS 100 > > The following patch backs out rev.1.119 of atapi-cd.c and fixes the > > following older devfs bugs in acd: > > - insecure permissions. Among other holes, these allowed the world to > > erase cd-rw's. > > Use rc.devfs for that as it was intended. rc.devfs is not intended for fixing kernel bugs. Bruce To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-current" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20021115211212.X13725-100000>