Date: Wed, 5 Aug 2009 19:13:42 GMT From: Robert Watson <rwatson@FreeBSD.org> To: Perforce Change Reviews <perforce@freebsd.org> Subject: PERFORCE change 167045 for review Message-ID: <200908051913.n75JDgeJ089442@repoman.freebsd.org>
next in thread | raw e-mail | index | archive | help
http://perforce.freebsd.org/chv.cgi?CH=167045 Change 167045 by rwatson@rwatson_cinnamon on 2009/08/05 19:13:26 Comment for the syscall code. Affected files ... .. //depot/projects/soc2009/marinosi_appaudit/src/sys/security/audit/audit_syscalls.c#6 edit Differences ... ==== //depot/projects/soc2009/marinosi_appaudit/src/sys/security/audit/audit_syscalls.c#6 (text) ==== @@ -540,6 +540,15 @@ return (EINVAL); return (audit_send_trigger(udata.au_trigger)); + /* + * XXXRW: as_name use a userspace character array, not a kernel space + * string pointer. We need to copyinstr() to a kernel character + * array for the purposes of looking it up, etc. + * + * XXXRW: Possibly audit_slice_*() should be able to return errors-- + * for example, if there's a name collision on creating slices, or i + * a slice can't be found for removal. + */ case A_CREATESLICE: if (uap->length != sizeof(udata.au_slice)) return (EINVAL);
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200908051913.n75JDgeJ089442>