From owner-freebsd-audit  Sat Jun  8 19: 2:34 2002
Delivered-To: freebsd-audit@freebsd.org
Received: from espresso.q9media.com (espresso.q9media.com [216.254.138.122])
	by hub.freebsd.org (Postfix) with ESMTP
	id E1DD237B401; Sat,  8 Jun 2002 19:02:31 -0700 (PDT)
Received: (from mike@localhost)
	by espresso.q9media.com (8.11.6/8.11.6) id g5920UE16403;
	Sat, 8 Jun 2002 22:00:30 -0400 (EDT)
	(envelope-from mike)
Date: Sat, 8 Jun 2002 22:00:30 -0400
From: Mike Barcroft <mike@FreeBSD.org>
To: Giorgos Keramidas <keramida@FreeBSD.org>
Cc: audit@FreeBSD.org
Subject: Re: minor header change in src/bin/dd/misc.c
Message-ID: <20020608220030.D87326@espresso.q9media.com>
References: <20020609014512.GA72307@hades.hell.gr>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20020609014512.GA72307@hades.hell.gr>; from keramida@FreeBSD.org on Sun, Jun 09, 2002 at 04:45:12AM +0300
Organization: The FreeBSD Project
Sender: owner-freebsd-audit@FreeBSD.ORG
Precedence: bulk
List-ID: <freebsd-audit.FreeBSD.ORG>
List-Archive: <http://docs.freebsd.org/mail/> (Web Archive)
List-Help: <mailto:majordomo@FreeBSD.ORG?subject=help> (List Instructions)
List-Subscribe: <mailto:majordomo@FreeBSD.ORG?subject=subscribe%20freebsd-audit>
List-Unsubscribe: <mailto:majordomo@FreeBSD.ORG?subject=unsubscribe%20freebsd-audit>
X-Loop: FreeBSD.ORG

Giorgos Keramidas <keramida@FreeBSD.org> writes:
> The source of bin/dd/misc.c doesn't use any of the functions of
> <strings.h> but uses strlen, which is defined in <string.h>.  The
> following seems to fix the only warning this file triggers for me.
> Does it seem ok to you all?

Yes, it's correct.  <strings.h> is almost always wrong for BSD code.
I removed the include of <string.h> from <strings.h> when I cleaned up
those headers for POSIX compatibility, so there are probably other
mis-includes throughout the system.

Best regards,
Mike Barcroft

To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-audit" in the body of the message