Skip site navigation (1)Skip section navigation (2)
Date:      Tue, 4 Sep 2001 10:14:25 -0700 (PDT)
From:      Matt Dillon <dillon@earth.backplane.com>
To:        John Baldwin <jhb@FreeBSD.ORG>
Cc:        Peter Wemm <peter@wemm.org>, cvs-committers@FreeBSD.ORG, cvs-all@FreeBSD.ORG
Subject:   Re: cvs commit: src/sys/kern kern_shutdown.c
Message-ID:  <200109041714.f84HEPQ92719@earth.backplane.com>
References:   <XFMail.010904094046.jhb@FreeBSD.org>

next in thread | previous in thread | raw e-mail | index | archive | help

:> John Baldwin wrote:
:>> 
:>> On 02-Sep-01 Peter Wemm wrote:
:>> > peter       2001/09/02 05:24:38 PDT
:>> > 
:>> >   Modified files:
:>> >     sys/kern             kern_shutdown.c 
:>> >   Log:
:>> >   The !RESTARTABLE_PANICS code has some loose ends.
:>> 
:>> What is holding_giant for?  Oh, and you do know that you are truly evil
:>> incarnate now, right?
:> 
:> I'm not sure.  Matt added it in rev 1.107, but the code that sets it is
:>#if 0'ed out.  It is a real mess.

    Please feel free to undo the holding_giant junk.  The issue is that 
    in at least one place Giant is obtained solely in order to call panic().
    If panic() returns there, Giant is left held because the calling code
    does not know panic might return, and will panic the machine again later.

    Of course, panic isn't really restartable in a large number of 
    situations so I think the holding_giant stuff should just be removed 
    entirely.

						-Matt


To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message




Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200109041714.f84HEPQ92719>