Skip site navigation (1)Skip section navigation (2)
Date:      Tue, 2 Apr 2002 01:55:41 -0800
From:      Kris Kennaway <kris@obsecurity.org>
To:        Maxim Konovalov <maxim@macomnet.ru>
Cc:        Kris Kennaway <kris@obsecurity.org>, Maxim Konovalov <maxim@FreeBSD.ORG>, cvs-committers@FreeBSD.ORG, cvs-all@FreeBSD.ORG
Subject:   Re: cvs commit: src/sbin/ping ping.c
Message-ID:  <20020402015540.A61991@xor.obsecurity.org>
In-Reply-To: <20020402134328.N10263-100000@news1.macomnet.ru>; from maxim@macomnet.ru on Tue, Apr 02, 2002 at 01:49:48PM %2B0400
References:  <20020402014214.A61546@xor.obsecurity.org> <20020402134328.N10263-100000@news1.macomnet.ru>

next in thread | previous in thread | raw e-mail | index | archive | help

--u3/rZRmxL6MmkK24
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Tue, Apr 02, 2002 at 01:49:48PM +0400, Maxim Konovalov wrote:
> On 01:42-0800, Apr 2, 2002, Kris Kennaway wrote:
>=20
> > On Tue, Apr 02, 2002 at 01:36:46AM -0800, Maxim Konovalov wrote:
> >
> > >   Submitted by:   kris (an early version of this patch)
> >
> > Does this really have anything in common with my patch?  The one I
> > recall writing a long time ago (but not committing) cleaned up
> > incorrect packet size and structure assumptions in the code.
>=20
> Yes, it does. I splitted your patch to four parts and Bruce Evans
> reviewed them. Of course, I made a lot of modifications and rewrote ip
> options parsing part completely but other are based on your patch and
> I thougth it was a good idea to mention about it. Did I do anything
> wrong?

I'm not saying there's anything wrong with it, I just must have been
thinking of a different patch (or maybe there were style fixes in the
one I am thinking of).

Kris

--u3/rZRmxL6MmkK24
Content-Type: application/pgp-signature
Content-Disposition: inline

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.0.6 (FreeBSD)
Comment: For info see http://www.gnupg.org

iD8DBQE8qYAcWry0BWjoQKURAnuRAJ9dKzY6eumFTX5bImDOUX+SZgki8wCgp3tJ
ENfP0IBk6ypNPu6mNzzl5GE=
=mIfq
-----END PGP SIGNATURE-----

--u3/rZRmxL6MmkK24--

To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message




Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20020402015540.A61991>