From owner-cvs-src@FreeBSD.ORG Fri May 21 12:31:43 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 23C9616A4CE; Fri, 21 May 2004 12:31:43 -0700 (PDT) Received: from rwcrmhc11.comcast.net (rwcrmhc11.comcast.net [204.127.198.35]) by mx1.FreeBSD.org (Postfix) with ESMTP id 1069543D45; Fri, 21 May 2004 12:31:43 -0700 (PDT) (envelope-from julian@elischer.org) Received: from interjet.elischer.org ([24.7.73.28]) by comcast.net (rwcrmhc11) with ESMTP id <2004052119310701300jd9g4e>; Fri, 21 May 2004 19:31:08 +0000 Received: from localhost (localhost.elischer.org [127.0.0.1]) by InterJet.elischer.org (8.9.1a/8.9.1) with ESMTP id MAA88068; Fri, 21 May 2004 12:31:06 -0700 (PDT) Date: Fri, 21 May 2004 12:31:05 -0700 (PDT) From: Julian Elischer To: John Baldwin In-Reply-To: <200405211007.06100.jhb@FreeBSD.org> Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII cc: cvs-src@FreeBSD.org cc: src-committers@FreeBSD.org cc: Thomas Moestl cc: cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/sparc64/sparc64 vm_machdep.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 21 May 2004 19:31:43 -0000 On Fri, 21 May 2004, John Baldwin wrote: > On Thursday 20 May 2004 04:04 pm, Julian Elischer wrote: > > On Thu, 20 May 2004, Thomas Moestl wrote: > > > On Thu, 2004/05/20 at 11:48:19 -0700, Julian Elischer wrote: > > > > While you are there, can you rename it to cpu_exit2() > > > > as it has nothing to do with the scheduler.. > > > > > > As I mentioned previously, the connection is that this function must > > > be called with sched_lock held (and it must be held until the final > > > cpu_throw() after that). It does tasks that have a connection to > > > thread switching, so the name is not really inappropriate. > > > > > > cpu_exit2 is far less descriptive as a name. > > > > but less misleading than cpu_sched_sxit() > > > > switching is nothing to do with the scheduler.. > > Uh, switching between threads is all the scheduler does. cpu_exit2() is a > horrible name. One question for Thomas, can the sparc64 cpu_switch() and/or jeff's scheduler interface leaves the switch code out of the scheduler interface.. The scheduler decides who to run but the switch code actually does it and is scheduler independent.. > cpu_throw() just call this function directly to avoid having exit1 > ()/thread_exit()/whoever know about it? not a bad idea. > > -- > John Baldwin <>< http://www.FreeBSD.org/~jhb/ > "Power Users Use the Power to Serve" = http://www.FreeBSD.org >