From owner-cvs-ports@FreeBSD.ORG  Fri May 27 03:08:41 2011
Return-Path: <owner-cvs-ports@FreeBSD.ORG>
Delivered-To: cvs-ports@FreeBSD.org
Received: by hub.freebsd.org (Postfix, from userid 1033)
	id 0ED3B106566B; Fri, 27 May 2011 03:08:41 +0000 (UTC)
Date: Fri, 27 May 2011 03:08:41 +0000
From: Alexey Dokuchaev <danfe@FreeBSD.org>
To: Gerald Pfeifer <gerald@pfeifer.com>
Message-ID: <20110527030841.GA3034@FreeBSD.org>
References: <201105151529.p4FFTU8x067633__20240.4801188552$1305473416$gmane$org@repoman.freebsd.org>
	<864o4lb1cy.fsf@gmail.com>
	<alpine.LNX.2.00.1105240029500.28383@gerinyyl.fvgr>
	<20110524011602.GA89360@FreeBSD.org>
	<alpine.LNX.2.00.1105252301570.26903@gerinyyl.fvgr>
Mime-Version: 1.0
Content-Type: text/plain; charset=koi8-r
Content-Disposition: inline
In-Reply-To: <alpine.LNX.2.00.1105252301570.26903@gerinyyl.fvgr>
User-Agent: Mutt/1.4.2.1i
Cc: David Naylor <naylor.b.david@gmail.com>, cvs-all@FreeBSD.org,
	ports-committers@FreeBSD.org, Pan Tsu <inyaoo@gmail.com>,
	cvs-ports@FreeBSD.org, Gerald Pfeifer <gerald@FreeBSD.org>
Subject: Re: cvs commit: ports/emulators Makefile ports/emulators/wine-gecko
	Makefile distinfo pkg-descr pkg-plist
X-BeenThere: cvs-ports@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: CVS commit messages for the ports tree <cvs-ports.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-ports>,
	<mailto:cvs-ports-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-ports>
List-Post: <mailto:cvs-ports@freebsd.org>
List-Help: <mailto:cvs-ports-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-ports>,
	<mailto:cvs-ports-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 27 May 2011 03:08:41 -0000

On Wed, May 25, 2011 at 11:03:53PM +0200, Gerald Pfeifer wrote:
> On Tue, 24 May 2011, Alexey Dokuchaev wrote:
> > I believe DATADIR is also mishandled in main wine port: that is, extra
> > "wine" word crept in (paths look like /usr/local/share/wine/wine/fonts/...
> > for example).
> 
> I've been wondering about that, too, but then it's been working for
> years and
> 
>   CONFIGURE_ARGS+=--datadir=${DATADIR} --verbose ...
> 
> looks pretty innocent, doesn't it?  Or is the concept of FreeBSD's
> ${DATADIR} so different from GNU's --datadir?

It *looks* innocent and natural, but it's wrong: our DATADIR is set to
${PREFIX}/share/${PORTNAME} by default, that is, it is fully qualified
path with port name included.  In GNU world, and particularly in wine
configure script, it is just a common prefix where GNU programs should
put their data; what is, for program `foo' it would be ${datadir}/foo.
When you assign FreeBSD ${DATADIR} as GNU --datadir, you get extra
"wine" path component, which is, of course, bogus and should be fixed.

As been previously mentioned, correctly respecting DATADIR and friends
never actually worded in FreeBSD.  I still use %%DATADIR%% macro in
plists but every time I do so without actually checking if DATADIR can
be set independently from PREFIX God kills a kitten.  :-(

./danfe