Skip site navigation (1)Skip section navigation (2) 
Date:      Wed, 27 Mar 2019 12:25:46 +0000 (UTC)
From:      Scott Long <scottl@FreeBSD.org>
To:        src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org
Subject:   svn commit: r345573 - in head/sys/dev: mpr mps
Message-ID:  <201903271225.x2RCPkfj050575@repo.freebsd.org>
next in thread | raw e-mail | index | archive | help 
Author: scottl
Date: Wed Mar 27 12:25:46 2019
New Revision: 345573
URL: https://svnweb.freebsd.org/changeset/base/345573

Log:
  Add missing break statements.  Coverity CID 1400446.
  
  Reported by:	mav

Modified:
  head/sys/dev/mpr/mpr_table.c
  head/sys/dev/mps/mps_table.c

Modified: head/sys/dev/mpr/mpr_table.c
==============================================================================
--- head/sys/dev/mpr/mpr_table.c	Wed Mar 27 11:03:07 2019	(r345572)
+++ head/sys/dev/mpr/mpr_table.c	Wed Mar 27 12:25:46 2019	(r345573)
@@ -451,6 +451,7 @@ mpr_print_evt_sas(struct mpr_softc *sc, MPI2_EVENT_NOT
 		MPR_PRINTFIELD(sc, data, DevHandle, 0x%x);
 		mpr_print_field(sc, "SASAddress: 0x%jx\n",
 		    mpr_to_u64(&data->SASAddress));
+		break;
 	}
 	case MPI2_EVENT_SAS_BROADCAST_PRIMITIVE:
 	{
@@ -461,6 +462,7 @@ mpr_print_evt_sas(struct mpr_softc *sc, MPI2_EVENT_NOT
 		MPR_PRINTFIELD(sc, data, Port, %d);
 		MPR_PRINTFIELD(sc, data, PortWidth, %d);
 		MPR_PRINTFIELD(sc, data, Primitive, 0x%x);
+		break;
 	}
 	default:
 		break;

Modified: head/sys/dev/mps/mps_table.c
==============================================================================
--- head/sys/dev/mps/mps_table.c	Wed Mar 27 11:03:07 2019	(r345572)
+++ head/sys/dev/mps/mps_table.c	Wed Mar 27 12:25:46 2019	(r345573)
@@ -430,6 +430,7 @@ mps_print_evt_sas(struct mps_softc *sc, MPI2_EVENT_NOT
 		MPS_PRINTFIELD(sc, data, DevHandle, 0x%x);
 		mps_print_field(sc, "SASAddress: 0x%jx\n",
 		    mps_to_u64(&data->SASAddress));
+		break;
 	}
 	case MPI2_EVENT_SAS_BROADCAST_PRIMITIVE:
 	{
@@ -440,6 +441,7 @@ mps_print_evt_sas(struct mps_softc *sc, MPI2_EVENT_NOT
 		MPS_PRINTFIELD(sc, data, Port, %d);
 		MPS_PRINTFIELD(sc, data, PortWidth, %d);
 		MPS_PRINTFIELD(sc, data, Primitive, 0x%x);
+		break;
 	}
 	default:
 		break;

Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201903271225.x2RCPkfj050575>