Date: Thu, 14 Dec 2006 04:55:08 GMT From: Craig Rodrigues <rodrigc@FreeBSD.org> To: eugen@grosbein.pp.ru, rodrigc@FreeBSD.org, freebsd-bugs@FreeBSD.org, rodrigc@FreeBSD.org Subject: Re: bin/105412: [patch] mount(8): msdosfs mounted as r/o cannot be remounted to r/w Message-ID: <200612140455.kBE4t8jZ018207@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
Synopsis: [patch] mount(8): msdosfs mounted as r/o cannot be remounted to r/w State-Changed-From-To: open->patched State-Changed-By: rodrigc State-Changed-When: Thu Dec 14 04:48:52 UTC 2006 State-Changed-Why: Very nice testcase. I made a shell script for it: #!/bin/sh dd if=/dev/zero bs=1k count=1440 of=image.msdos mdconfig -a -t vnode -f image.msdos newfs_msdos -f 1440 /dev/md0 mount_msdosfs -o ro /dev/md0 /mnt mount | grep md0 mount -u -o rw /dev/md0; echo $? mount | grep md0 Take a look at src/sys/fs/msdosfs/msdosfs_vfsops.c version 1.144.2.7. For me, that makes your testcase pass on RELENG_6. The patch that you posted for mount(8) is only used for "mount -a", so doesn't handle your testcase. Responsible-Changed-From-To: freebsd-bugs->rodrigc Responsible-Changed-By: rodrigc Responsible-Changed-When: Thu Dec 14 04:48:52 UTC 2006 Responsible-Changed-Why: Very nice testcase. I made a shell script for it: #!/bin/sh dd if=/dev/zero bs=1k count=1440 of=image.msdos mdconfig -a -t vnode -f image.msdos newfs_msdos -f 1440 /dev/md0 mount_msdosfs -o ro /dev/md0 /mnt mount | grep md0 mount -u -o rw /dev/md0; echo $? mount | grep md0 Take a look at src/sys/fs/msdosfs/msdosfs_vfsops.c version 1.144.2.7. For me, that makes your testcase pass on RELENG_6. The patch that you posted for mount(8) is only used for "mount -a", so doesn't handle your testcase. http://www.freebsd.org/cgi/query-pr.cgi?pr=105412
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200612140455.kBE4t8jZ018207>