Date: Wed, 27 Jan 1999 23:26:54 -0700 From: Nate Williams <nate@mt.sri.com> To: Matthew Dillon <dillon@apollo.backplane.com> Cc: Nate Williams <nate@mt.sri.com>, "Justin T. Gibbs" <gibbs@plutotech.com>, cvs-committers@FreeBSD.ORG, cvs-all@FreeBSD.ORG Subject: Re: cvs commit: src/sys/i386/eisa ahb.c Message-ID: <199901280626.XAA26749@mt.sri.com> In-Reply-To: <199901280609.WAA93705@apollo.backplane.com> References: <199901280133.RAA40079@freefall.freebsd.org> <199901280332.UAA25969@pluto.plutotech.com> <199901280546.WAA26358@mt.sri.com> <199901280609.WAA93705@apollo.backplane.com>
next in thread | previous in thread | raw e-mail | index | archive | help
> :> > Revision Changes Path > :> > 1.5 +7 -2 src/sys/i386/eisa/ahb.c > :> > :> There certainly was a bug there, but your commit made the driver > :> non-functional. Why not pass your concern on to the author/maintainer of > :> the driver instead of committing something that does not address the > :> problem? If I had missed your checkin mail, I would never have noticed the > :> bug especially after you cleared the compiler warning without really fixing > :> the problem. > : > :Justin's response is *exactly* the kind of thing that striving for -Wall > :buys us. We're fixing the warning, but not the problem. > > Bullshit. You don't know what the fuck you are talking about. I don't know that you screwed up in your quest to fix a warning? Gee, forgive me for sounding suprised, but: "Matt, you screwed up with your fix that tried to fix a -Wall warning". The fix was wrong. Wrong. Wrong. If you don't understand it, don't fix it and leave the warning. The warning is there for a reason, and making it go away because it bothers you is *WRONG* WRONG *WRONG*. Sheesh. > I > committed the adjustment, but it was plainly suspicious to me that > I pushed it out to the lists and left it on my hotlist. And committed the *wrong* fix w/out allowing any feedback from the folks who could fix it correctly, in order to make the warning go away. If Justin wouldn't have noticed it, the 'error' would have been that much harder to fine. > This is one adjustment out of over 800 that I've committed today. Did I say that all of those 800 adjustments were flawed? Nope, but in shows that making warnings go away w/out understanding the issues is the *wrong* solution. (Have I made it obvious that I think this is the 'wrong' thing to do yet?) > If you > want to spend the time to go through each and every one of them like > I have, then you have a right to comment on it. But otherwise, I am > not interested in people sitting on the sidelines making reactionary > ( and completely unsupported) comments about things they have no clue > about because they haven't bothered to run through what's been done. I'm not about to go review all of your changes, simply because it would be silly. But, by making them w/out any feedback at all, even when you admit not understanding the issues is simply *wrong*. > This is also ridiculous. Zealots? Excuse me? It's the next logical > step in cleaning up the code and cleaning up the compiler options > we use. Great, then only do it if you understand it. Like you've done for a number of things. My problem is that you commit your 'compiler cleanups' even though you've never even given anyone a chance to comment on it, thus making it that much harder for those of us who actually *want* to understand what you're do. Nate To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?199901280626.XAA26749>